Actions
Bug #2199
closed
Git commit error on auto-archive should be a system error in log, not a user one
Status:
Released
Priority:
3
Assignee:
Category:
Web - Maintenance
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Description
The rational behind that is:
- the user see a "save PI error: file was not saved in Git", or "moving group error: file was not saved in Git", or other error like that but he can't do anything - and taking the same action will show the same error
- modification on the PI/Group/CR etc are already commited in the LDAP, and can't be easely rollbacked
- XML archiving in the FS managed by Git is more a system settings than one up to the user setting a description to a group.
So, the idea will be to log these error the application log in place of having them poping into user face.
Updated by François ARMAND almost 13 years ago
- Target version changed from 2.4.0~alpha4 to 2.4.0~alpha5
Updated by François ARMAND almost 13 years ago
- Status changed from 2 to Pending technical review
- % Done changed from 0 to 100
Done in commit ad6fddd8
Updated by Nicolas CHARLES almost 13 years ago
- Status changed from Pending technical review to In progress
- % Done changed from 100 to 90
This does look valid, but an error shouldn't be logged in a logger.error rather than a logger.debug ??
Updated by François ARMAND almost 13 years ago
That's right, it makes more sense to log them in error.
Updated by François ARMAND almost 13 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 90 to 100
Applied in changeset d8a3ab0b02440aab05daeb664548447ae9e7bad5.
Updated by Nicolas CHARLES almost 13 years ago
- Status changed from Pending technical review to Released
Thank you Francois
Actions