Project

General

Profile

Actions

Bug #2216

closed

Compilation of rudder-core is really slows and fails on the CI

Added by Nicolas CHARLES almost 13 years ago. Updated over 12 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Architecture - Code maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Since the modification of eventlogs, the compilation of rudder-core is really slow, and fails on the CI since the compiler does a stackoverflow
It may be linked to too large pattern matching, which should be changed to partial function for this very use case

Actions #1

Updated by Nicolas CHARLES almost 13 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100
Actions #2

Updated by François ARMAND almost 13 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Nicolas CHARLES to François ARMAND

The error is still here.

I believe that the error is due to different ergonomics of the JDK in the chroot environment, but I don't know why Hotstop may choose a different stack size. Forcing the compiler to run on a server VM and/or having a stacksize of anything equals or above 512k remove the bug (512k is very small, default server stack size is 2Mo).

I propose to simply use server compiler, as it's where innovation is coming from in all case.

Actions #3

Updated by François ARMAND almost 13 years ago

  • Status changed from In progress to Pending technical review
Actions #4

Updated by François ARMAND almost 13 years ago

The technical review is ok. I'm waiting for our CI to bet set-up again to validate that everything actually works has wanted.

Actions #5

Updated by Matthieu CERDA over 12 years ago

This looks OK to me, but I think an experienced Java user should validate it too...

Actions #6

Updated by François ARMAND over 12 years ago

  • Status changed from Pending technical review to Released
Actions

Also available in: Atom PDF