Project

General

Profile

Actions

Architecture #22723

closed

Backport scala 2.13 change for scala 3.0 migration

Added by François ARMAND about 1 year ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Internal libs
Target version:
Effort required:
Name check:
To do
Fix check:
Checked
Regression:
No

Description

We need to backport changes compatible with scala 2.13 from that PR: https://github.com/Normation/rudder/pull/4603

It seems that we can backport:

Remove more warnings - use case when narrowing to JField type in for-…
…comprehenison. It would introduce withFilter calls allowing for safer parsing. Seems very simple and low risk (adding case in for loop) 2.13 https://github.com/Normation/rudder/pull/4603/commits/00eeb1fb2fd5f4718ae2cdcd35eb9530fac05be0
Remove more warnings - explicit .apply method calls Seems very simple and low risk (adding case in for loop) 2.13 https://github.com/Normation/rudder/pull/4603/commits/7bc1b1ac4bdc52128b30f154c099b7b647dbe640
Limit warnings - replace remove final modifier from objects Seems very simple and low risk (adding case in for loop) 2.13 https://github.com/Normation/rudder/pull/4603/commits/665780033793b410da7a9635f6300093069561d8
Fix version or wartremover we could remove wartremover completly 2.13 https://github.com/Normation/rudder/pull/4603/commits/b7aab817c0b09cdd67df8418952add71a2e6ffa1
Comment out strane not compiling test ⚠️look at that ? 2.13 https://github.com/Normation/rudder/pull/4603/commits/a5e7500d9246c9d20326cd5643d896451b90c4f2
Comment out XML comments due to regression in parser of Scala3 comments can be removed 2.13 https://github.com/Normation/rudder/pull/4603/commits/8a63484cb885884c412408323fcd96680e577665
Use DefaultFormsts instead of Serialization.formats(NoTypeHints) due …
…to Scala bug lampepfl/dotty#16443 ⚠️check what it means for the resulting JSON, test on 2.13.Perhaps need to rewrite these parts with `zio-json` 2.13 https://github.com/Normation/rudder/pull/4603/commits/1e1a14cf246bd1b59334716a6c05936fb3969bbf
Move testing rudder-parsers to rudder-core due to problems with depen…
…dencies 🆗 2.13 https://github.com/Normation/rudder/pull/4603/commits/5003bd4619577c47eebab921f62961d504420354
Replace silencer plugin with scala.annotation.nowarn We should do it in 2.13 2.13 https://github.com/Normation/rudder/pull/4603/commits/4b6c17a558ddcb172c7874eefd60bce6c3c9be53
Fix problems with implicit conversions in ConfigService 🆗 2.13 https://github.com/Normation/rudder/pull/4603/commits/d20764c038029ce7854cb13f986910f72ff7f7fd
Disable always failing assertion ⚠️What ? Need to be investigated 2.13 https://github.com/Normation/rudder/pull/4603/commits/263fb0c6ee4ea0e69e5c2765268f59b69a58bb14
Workaround dropped Scala feature: General Type Projection https://dot
…ty.epfl.ch/docs/reference/dropped-features/type-projection.html Seems that we can do that in 2.13 2.13 https://github.com/Normation/rudder/pull/4603/commits/ee2e28f40427f1f4bc124883f36fc4cdd90f914c
Mittigate some of the known Dotty bugs Seems that we can do that in 2.13 2.13 https://github.com/Normation/rudder/pull/4603/commits/b706c21fc19fd2536aaf2ec3c360e426ddc1c992
Remove implicit conversion introduced by lift-json: String ++ String was converted into JArray(List(_, _)) 😱 2.13 https://github.com/Normation/rudder/pull/4603/commits/a7c92f06edd5b02f240edcb95e06135a46dda429
Fix Scala XML source incompatibilities the gift that keeps giving 2.13 https://github.com/Normation/rudder/pull/4603/commits/02575dfa8bc9fc5abca7b9e525c45308fe39c97c
Allow to compile ldap modules with Scala3 It seems that most of that can go in 2.13 2.13 https://github.com/Normation/rudder/pull/4603/commits/f7531ea9903c3af42c983f8054c92fd69ad58c65
Allow to compile utils with Scala 3 2.13 https://github.com/Normation/rudder/pull/4603/commits/8959e0e4782ec7e250a99fce500c11d2b96f8e50


Subtasks 4 (0 open4 closed)

Rudder plugins - Architecture #22759: Reflect changes from scala 3 backport in pluginsReleasedVincent MEMBRÉActions
Rudder plugins - Bug #22770: Reflect changes of 7.3 backport to datasource pluginReleasedFrançois ARMANDActions
Rudder plugins - Bug #22771: Still some chances to datasource for 7.3 backport ReleasedFrançois ARMANDActions
Architecture #22764: Correct warning due to nowarn or release in 7.2 branchReleasedVincent MEMBRÉActions

Related issues 1 (1 open0 closed)

Related to Rudder - Architecture #24814: Scala 3 migrationNewActions
Actions #1

Updated by François ARMAND about 1 year ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #2

Updated by François ARMAND about 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/4783
Actions #3

Updated by François ARMAND about 1 year ago

  • Target version changed from 8.0.0~alpha1 to 7.2.7

We should do that in 7.2 to avoid as many merge conflict as we can in the futur

Actions #4

Updated by François ARMAND about 1 year ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions #5

Updated by François ARMAND about 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request changed from https://github.com/Normation/rudder/pull/4783 to https://github.com/Normation/rudder/pull/4789
Actions #6

Updated by François ARMAND about 1 year ago

  • Subtask #22759 added
Actions #7

Updated by Anonymous about 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #8

Updated by François ARMAND about 1 year ago

  • Subtask #22764 added
Actions #9

Updated by Vincent MEMBRÉ about 1 year ago

  • Fix check changed from To do to Checked
Actions #10

Updated by Vincent MEMBRÉ about 1 year ago

This bug has been fixed in Rudder 7.2.7 and 7.3.2 which were released today.

Actions #11

Updated by Vincent MEMBRÉ 4 months ago

  • Status changed from Pending release to Released
Actions #12

Updated by François ARMAND 3 months ago

Actions

Also available in: Atom PDF