Project

General

Profile

Actions

Bug #23553

closed

Override process of properties is very misleading at node level

Added by Félix DALLIDET 7 months ago. Updated 7 months ago.

Status:
Released
Priority:
N/A
Category:
Web - Nodes & inventories
Target version:
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
UX impact:
I hate Rudder for that
User visibility:
Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required:
Medium
Priority:
125
Name check:
To do
Fix check:
To do
Regression:
No

Description

When a property is inherited by a group, to override it at a node level, you have to:
  • create a property with the same name to override it, but then, you "loose" the information of what the local override value was as only the merged result is displayed.
  • if a local override already exists, you have to use the "edit" button on the property, but it displays whole "merged result" to edit instead of the local override already defined, which mean that a non attentive user will create a faulty local override without knowing it, and will prevent the node to receive any value update from the group

An example below:
In my group Ubuntu, I define the following "test" property:

{"a": "a", "b": "b", "c":"c"}

On a node within this group, I define a new property "test" as:

{"b": "bob"}

The resulting effective property is:

{
  "a": "a",
  "b": "bob",
  "c": "c" 
}

So far, everything it fine, except that I "lost" the information of what is the value of my local override (it is displayed on the tooltip, which is not super user friendly)

Now, I want to modify the local override to change the value of a, I have to click on the "edit" button of the property, which displays the current effective value to edit:

{
  "a": "a",
  "b": "bob",
  "c": "c" 
}

Which I modify to:
{
  "a": "alice",
  "b": "bob",
  "c": "c" 
}

This is the big issue here, my local override now also contains an override to the "c" key, which I did not want.
To demonstrate it, if I go back to the group node page and modify the initial "test" property to:

{"a": "a", "b": "b", "c":"charly"}

The charly value will never reach the node...


Related issues 1 (0 open1 closed)

Has duplicate Rudder - Bug #23615: The value edited for overridden properties in node is not the node valueResolvedRaphael GAUTHIERActions
Actions #1

Updated by Raphael GAUTHIER 7 months ago

  • Status changed from New to In progress
  • Assignee set to Raphael GAUTHIER
Actions #2

Updated by Raphael GAUTHIER 7 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/5087
Actions #3

Updated by Raphael GAUTHIER 7 months ago

  • Status changed from Pending technical review to Pending release
Actions #5

Updated by Vincent MEMBRÉ 7 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 8.0.0~rc2 which was released today.

Actions #6

Updated by Raphael GAUTHIER 6 months ago

  • Has duplicate Bug #23615: The value edited for overridden properties in node is not the node value added
Actions

Also available in: Atom PDF