Project

General

Profile

Actions

Bug #23932

closed

Plugin license implementation is not coherent with interface

Added by Vincent MEMBRÉ 5 months ago. Updated 3 months ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Internal libs
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:
No

Description

We implement "isEnabled" plugin by a val in some implementation, and by a def without parameter in the trait. the trait defines a def without parameter.

This makes that implementation by a val are not exactly the same but compilation is ok (not a problem until compiler behaviour change)

but this prevent calling with parenthesis, val does not support it, so in some plugin where we use this type, we cannot use parenthesis, because val fails to build.

In licensed build, we use an implementation with parenthesis, but we cannot use parenthesis due to unlicensed version, and this was producing a warning (call without parenthesis deprecated, removed in scala3) and since we removed warning, this make the licensed version of some plugin not buildable for releases.

Actions #1

Updated by Vincent MEMBRÉ 5 months ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions #2

Updated by Vincent MEMBRÉ 5 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/5271
Actions #3

Updated by Anonymous 5 months ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by Alexis Mousset 4 months ago

  • Fix check changed from To do to Checked
Actions #5

Updated by Vincent MEMBRÉ 3 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.3.11 which was released today.

Actions

Also available in: Atom PDF