Project

General

Profile

Actions

Enhancement #24091

closed

Add manufacturer field in create node API

Added by François ARMAND 3 months ago. Updated 3 months ago.

Status:
Released
Priority:
N/A
Category:
API
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
To do
Fix check:
Checked
Regression:
No

Description

We want to add a manufacturer field in create node api. To do that, we want to make the format for machine that we have for node details be available for creation:

...
        "machine": {
          "id": "400c9f3f-0f6a-4e87-8db0-250a8440bd11",
          "type": "Virtual",
          "provider": "qemu",
          "manufacturer": "QEMU" 
        },
...

The semantic would be:
- if both machine and machineType are present, prefer machine which would become the default at some point
- provider and manufacturer are optionnal
- type take "physical" or "virtual"


Files

clipboard-202401301457-bn4kv.png (57.2 KB) clipboard-202401301457-bn4kv.png François ARMAND, 2024-01-30 14:57

Subtasks 1 (0 open1 closed)

Enhancement #24105: Machine is not correctly create with node create APIReleasedVincent MEMBRÉActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #24141: Bad description for serialNumber attribute of machineReleasedVincent MEMBRÉActions
Actions #1

Updated by François ARMAND 3 months ago

  • Status changed from New to In progress
Actions #2

Updated by François ARMAND 3 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/5358
Actions #3

Updated by Anonymous 3 months ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by François ARMAND 3 months ago

The manufacturer is correctly understood by the API, but then the machine is not correctly create and saved in base

Actions #5

Updated by François ARMAND 3 months ago

  • Subtask #24105 added
Actions #6

Updated by François ARMAND 3 months ago

  • Fix check changed from Error - Blocking to Checked
Actions #7

Updated by Vincent MEMBRÉ 3 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.3.11 which was released today.

Actions #8

Updated by François ARMAND 3 months ago

  • Related to Bug #24141: Bad description for serialNumber attribute of machine added
Actions

Also available in: Atom PDF