Project

General

Profile

Actions

Bug #24583

closed

We should not be able to save a technique with empty enum parameters

Added by Clark ANDRIANASOLO 8 months ago. Updated 8 months ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
I dislike using that feature
User visibility:
Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required:
Medium
Priority:
58
Name check:
To do
Fix check:
To do
Regression:
No

Description

When creating a new Technique and in the Parameters tab,

  • I could save an Enum parameter with filling anything (for Display name and Value) :

=> But when creating a directive from it displays an error, for example when two parameters have "empty enums" we have both errors :

  • Also, when we only fill Display name, we get the display name but the same error at save (because the value are still "empty")
  • Lastly, when both values are filled, in the directive parameters it is impossible to have a default value (but in the illegal case when Value is empty, it is selected by default)
To fix this :
  • we should display an error and should not be able to save a technique when at least one Enum has an empty Value
  • we should add a hint that Display name is optional and will inherit Value if empty
  • we should have the possibility to input a default value for an enum (by selecting one of the values) and for a text

Files

clipboard-202403221725-n0vwr.png (41.4 KB) clipboard-202403221725-n0vwr.png Clark ANDRIANASOLO, 2024-03-22 17:25
clipboard-202403221726-cmveq.png (53 KB) clipboard-202403221726-cmveq.png Clark ANDRIANASOLO, 2024-03-22 17:26
clipboard-202403221735-b7bz8.png (55.3 KB) clipboard-202403221735-b7bz8.png Clark ANDRIANASOLO, 2024-03-22 17:35
clipboard-202403221738-zqt7t.png (55 KB) clipboard-202403221738-zqt7t.png Clark ANDRIANASOLO, 2024-03-22 17:38

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #24594: We can't save a technique with an enum value empty while required option is uncheckedReleasedVincent MEMBRÉActions
Actions #2

Updated by Elaad FURREEDAN 8 months ago

  • Status changed from New to In progress
  • Assignee set to Elaad FURREEDAN
Actions #3

Updated by Elaad FURREEDAN 8 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Elaad FURREEDAN to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/5520
Actions #4

Updated by Anonymous 8 months ago

  • Status changed from Pending technical review to Pending release
Actions #5

Updated by Elaad FURREEDAN 8 months ago

  • Related to Bug #24594: We can't save a technique with an enum value empty while required option is unchecked added
Actions #6

Updated by Vincent MEMBRÉ 8 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 8.1.0~rc1 which was released today.

Actions

Also available in: Atom PDF