Rudder

1. a kept_if_else is used on a command execution, when the command execution can only return repaired or fail
2. the /etc/group is edited only if the group doesn't exist, or if a mysterious class group_$(index)_created is defined

The success depend on the file edition to be successful, which never happens

Applied in changeset commit:42f1b85e25c8e6ad3d590f8580ac4b50de7a7930.

I'm not convinced about this fix.

There are two operations in the main bundle here: one adds the group if it doesn't exist (addgroup command) and one populates the group with it's members (/etc/group file edit_line).

However, the change introduced by this commit (42f1b85e) modifies the ifvarclass condition of the files promise. As a result, it no longer edits the file after creating the group. This condition should be, in plain English, "only edit the groups file if the group $(name) is already in it". So why not use "ifvarclass => !group_$(index)_absent|group_$(index)_added"?

Applied in changeset commit:b93d5a7cac61b65908d3a33dc08f32277973acf3.

OK, this fix looks good to me, thanks.