Bug #24867: No error toast when a pending node can't be accepted because hostname already exists - Rudder - Issue Tracker

Actions

Copy link

Bug #24867

open

No error toast when a pending node can't be accepted because hostname already exists

Added by François ARMAND 7 months ago. Updated 20 days ago.

Status:

New

Priority:

N/A

Assignee:

Raphael GAUTHIER

Category:

Web - Nodes & inventories

Target version:

8.1.11

Pull Request:

Severity:

Minor - inconvenience | misleading | easy workaround

UX impact:

I dislike using that feature

User visibility:

Operational - other Techniques | Rudder settings | Plugins

Effort required:

Very Small

Priority:

Name check:

To do

Fix check:

To do

Regression:

Description

If we try to accept a pending node while its hostname matches a node already accepted, the node is refused and we have in logs:

2024-05-16 13:17:09+0000 ERROR nodes.pending - Error when trying to accept node with id 'b522c78a-3dd6-48c0-b242-71da15c99109': Inconsistency: There is already a node with hostname 'node1.rudder.local' in Rudder. You can not add it again.

This is expected and that behavior can be change with the setting:

curl -k  -H "X-API-Token: xxxxx" -H "Content-Type: application/json" -X POST 'http://localhost:8082/rudder-web/api/latest/settings/node_accept_duplicated_hostname' -d '{"value":true}'

But we don't have an error notification in the UI

Files

clipboard-202405161626-lnle7.png (22.5 KB) clipboard-202405161626-lnle7.png

François ARMAND, 2024-05-16 16:26

Actions

Copy link

Updated by François ARMAND 7 months ago

Status changed from New to In progress
Assignee set to François ARMAND

Actions

Copy link

Updated by François ARMAND 7 months ago

File clipboard-202405161626-lnle7.png clipboard-202405161626-lnle7.png added
Status changed from In progress to New
Assignee changed from François ARMAND to Raphael GAUTHIER
Severity set to Minor - inconvenience | misleading | easy workaround
UX impact set to I dislike using that feature
User visibility set to Operational - other Techniques | Rudder settings | Plugins
Effort required set to Very Small
Priority changed from 0 to 85

OK, so the error is their, it's just that its style disappeared in 8.1:

<div class="tab-pane active" id="review_new_server" role="tabpanel">
                    <div class="callout-fade callout-info">
                      <div class="marker">
                        <span class="fa fa-info-circle"></span>
                      </div>
                      <p>Click on a node name to view detailed inventory information.</p>
                      <p>Click on <i class="fa fa-search"></i>to list Rules that would be applied to this node if you accept it.</p>
                    </div>
                    <div id="lift__noticesContainer__"><div id="lift__noticesContainer___error"><ul><li><span>
            Inconsistency: There is already a node with hostname 'node1.rudder.local' in Rudder. You can not add it again.
          </span></li></ul></div></div>
                    <div>
                      <div>

  <div id="acceptNodeGrid_wrapper" class="dataTables_wrapper no-footer"><div class="dataTables_wrapper_top">
....

Actions

Copy link