Project

General

Profile

Actions

Architecture #25091

open

Add VARIABLE_NAME to technique so that we can use valid parameter name in techniques

Added by Vincent MEMBRÉ 24 days ago. Updated 9 days ago.

Status:
Pending release
Priority:
N/A
Category:
Web - Config management
Target version:
Effort required:
Name check:
To do
Fix check:
To do
Regression:
No

Description

in 8.0.4 we normalized the state of name and description of technique parameters (see https://issues.rudder.io/issues/23847)

But we still used a generated id to find the value. We should use the parameter name which is unique within a technique (or else the value won't be usable)

This change lead to a bug in generation for windows nodes where we now use the description instead of the variable when a description was defined. (we fallbacked to the name if it was missing)

It simplifies lots of things and is not related to reporting.

Actions #1

Updated by Vincent MEMBRÉ 24 days ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions #2

Updated by Vincent MEMBRÉ 24 days ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/5756
Actions #3

Updated by Vincent MEMBRÉ 24 days ago

  • Subject changed from Use name of technique parameter as name (and identifier) instead of an id and description in various cases to Add VARIABLE_NAME to technique so that we can use valid parameter name in techniques
  • Status changed from Pending technical review to New
  • Assignee deleted (François ARMAND)
  • Pull Request deleted (https://github.com/Normation/rudder/pull/5756)
Actions #4

Updated by Vincent MEMBRÉ 24 days ago

  • Status changed from New to Pending technical review
  • Assignee set to François ARMAND
Actions #5

Updated by Vincent MEMBRÉ 23 days ago

  • Target version changed from 8.0.10 to 1089
Actions #7

Updated by François ARMAND 22 days ago

  • Pull Request set to https://github.com/Normation/rudder/pull/5756
Actions #8

Updated by François ARMAND 13 days ago

  • Status changed from Pending technical review to In progress

I'm taking over this issue!

Actions #9

Updated by François ARMAND 12 days ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request changed from https://github.com/Normation/rudder/pull/5756 to https://github.com/Normation/rudder/pull/5769
Actions #10

Updated by Anonymous 12 days ago

  • Status changed from Pending technical review to Pending release
Actions #11

Updated by Alexis Mousset 9 days ago

  • Target version changed from 1089 to 8.1.6
Actions

Also available in: Atom PDF