Architecture #25091: Add VARIABLE_NAME to technique so that we can use valid parameter name in techniques - Rudder - Issue Tracker

Actions

Copy link

Architecture #25091

closed

Add VARIABLE_NAME to technique so that we can use valid parameter name in techniques

Added by Vincent MEMBRÉ 4 months ago. Updated 3 months ago.

Status:

Released

Priority:

N/A

Assignee:

Vincent MEMBRÉ

Category:

Web - Config management

Target version:

8.1.6

Pull Request:

https://github.com/Normation/rudder/p...

Effort required:

Name check:

To do

Fix check:

Checked

Regression:

Description

in 8.0.4 we normalized the state of name and description of technique parameters (see https://issues.rudder.io/issues/23847)

But we still used a generated id to find the value. We should use the parameter name which is unique within a technique (or else the value won't be usable)

This change lead to a bug in generation for windows nodes where we now use the description instead of the variable when a description was defined. (we fallbacked to the name if it was missing)

It simplifies lots of things and is not related to reporting.

Actions

Copy link

Updated by Vincent MEMBRÉ 4 months ago

Status changed from New to In progress
Assignee set to Vincent MEMBRÉ

Actions

Copy link

Updated by Vincent MEMBRÉ 4 months ago

Status changed from In progress to Pending technical review
Assignee changed from Vincent MEMBRÉ to François ARMAND
Pull Request set to https://github.com/Normation/rudder/pull/5756

PR https://github.com/Normation/rudder/pull/5756

Actions

Copy link

Updated by Vincent MEMBRÉ 4 months ago

Subject changed from Use name of technique parameter as name (and identifier) instead of an id and description in various cases to Add VARIABLE_NAME to technique so that we can use valid parameter name in techniques
Status changed from Pending technical review to New
Assignee deleted (~~François ARMAND~~)
Pull Request deleted (~~https://github.com/Normation/rudder/pull/5756~~)

Actions

Copy link

Updated by Vincent MEMBRÉ 4 months ago

Status changed from New to Pending technical review
Assignee set to François ARMAND

Actions

Copy link

Updated by Vincent MEMBRÉ 4 months ago

Target version changed from 8.0.10 to 1089

Actions

Copy link

Updated by François ARMAND 4 months ago

Pull Request set to https://github.com/Normation/rudder/pull/5756

Actions

Copy link

Updated by François ARMAND 4 months ago

Status changed from Pending technical review to In progress

I'm taking over this issue!

Actions

Copy link

Updated by François ARMAND 4 months ago

Status changed from In progress to Pending technical review
Assignee changed from François ARMAND to Vincent MEMBRÉ
Pull Request changed from https://github.com/Normation/rudder/pull/5756 to https://github.com/Normation/rudder/pull/5769

PR https://github.com/Normation/rudder/pull/5769

Actions

Copy link

#10