Project

General

Profile

Actions

Architecture #25092

closed

Architecture #24963: Persist compliance in base to know last state for a long time

Refactor CachedReportingService to make persistance simpler

Added by François ARMAND 23 days ago. Updated about 9 hours ago.

Status:
Released
Priority:
N/A
Category:
Architecture - Code maintenance
Target version:
Effort required:
Name check:
To do
Fix check:
To do
Regression:
No

Description

CachedReportingService is very complicated and mix at least four function (getting runs & expected config, computing compliance and checking compliance, having a cache, and higher level utility methods on NodeStatusReport).

We want to split these different part to have a clear NodeStatusReportRepository where to add persistance, and a clear ComputeNodeStatusReports where to modify expiration checks based on new parameter.

This first step should not modify too much current implementation, just simplify things where it's obvious (unused parameters, etc).
It's also time to get ride of the all-commented ReportingServiceTest, so that we can build a simpler, better suite afterward.

Actions #1

Updated by François ARMAND 23 days ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #2

Updated by François ARMAND 23 days ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Clark ANDRIANASOLO
  • Pull Request set to https://github.com/Normation/rudder/pull/5757
Actions #3

Updated by Anonymous 21 days ago

  • Status changed from Pending technical review to Pending release
Actions #4

Updated by Alexis Mousset about 9 hours ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 8.2.0~alpha1 which was released today.

Actions

Also available in: Atom PDF