Project

General

Profile

Actions

Bug #2565

closed

When we receive an inventory from a deleted node, the inventory stays deleted

Added by Nicolas CHARLES over 12 years ago. Updated over 12 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Web - Nodes & inventories
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I have deleted nodes for the sake of testing. Then I wanted to add them back in Rudder, however, since their inventory were in the RemovedInventory branch, new inventories goes there.
What would be the expected behaviour ?

I would suspect that we'd want it moved to the Pending Inventory, but if it is so, deleted nodes would keep poping back in the pending nodes, unless somebody goes and removes rudder-agent on them

Actions #1

Updated by Jonathan CLARKE over 12 years ago

  • Status changed from New to Discussion
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Nicolas CHARLES wrote:

I have deleted nodes for the sake of testing. Then I wanted to add them back in Rudder, however, since their inventory were in the RemovedInventory branch, new inventories goes there.
What would be the expected behaviour ?

The current behaviour would completely prevent someone from doing this: "Delete that node from Rudder. [A few weeks later] OK, add it back in".

I would suspect that we'd want it moved to the Pending Inventory,

I agree with this proposed behaviour. Ideally, we would like to see an extra field, saying "Deleted from Rudder on: 2012-06-11 18:40".

but if it is so, deleted nodes would keep poping back in the pending nodes, unless somebody goes and removes rudder-agent on them

This limitation is already the same as for refused nodes - it's really up to the admin to be able to remove rudder-agent from the node in question... Or, of course, we could have a "blacklist" button to make sure that this node doesn't keep appearing...

Actions #2

Updated by Jonathan CLARKE over 12 years ago

  • Tracker changed from Question to Bug
  • Subject changed from When we receive an inventory from a deleted node, the inventory stays deleted. to When we receive an inventory from a deleted node, the inventory stays deleted
  • Status changed from Discussion to 2

Nicolas, do you need any more information on this to be able to fix?

Actions #3

Updated by Nicolas CHARLES over 12 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 0 to 100
Actions #4

Updated by François ARMAND over 12 years ago

  • Status changed from Pending technical review to Released

That's OK and I'm really happy with the cleaness of the code! Only that to add that feature is pretty cool :)

Actions

Also available in: Atom PDF