Actions
Bug #25713
closedReportsExecution doesn't have timezone on all fields
Status:
Released
Priority:
N/A
Assignee:
Category:
Web - Compliance & node report
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:
No
Description
We have two columns in ReportsExecution that are timestamp without timezone.
Updated by François ARMAND about 2 months ago
- Status changed from New to In progress
Updated by François ARMAND about 2 months ago
So, these two fields are not used much:
insertiondate
is mapped toAgentRunWithoutCompliance.insertionDate
which is never read. It's only modified when the report is insertedcompliancecomputationdate
is read but only to check if null or set.
ReportsExecutionRepositoryImpl.scala ... 79 s"""SELECT nodeid, date, nodeconfigid, insertionid, insertiondate FROM ReportsExecution where compliancecomputationdate is null""" ... 131 |( SELECT nodeid, max(date)) FROM ReportsExecution where compliancecomputationdate is not null group by nodeid)""".stripMargin) ... reportsSchema.sql ... CREATE INDEX reportsexecution_uncomputedrun_idx on ReportsExecution (compliancecomputationdate) where compliancecomputationdate IS NULL; ...
So we can alter the column type violently without changing behavior, not caring for existing data.
Updated by François ARMAND about 2 months ago
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Clark ANDRIANASOLO
- Pull Request set to https://github.com/Normation/rudder/pull/5959
Updated by Anonymous about 1 month ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|4da4bd3a6cd83ba7cb5de281a3c1ff17ff2b33c9.
Updated by Alexis Mousset about 1 month ago
- Fix check changed from To do to Checked
Updated by Vincent MEMBRÉ about 1 month ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 8.1.8 and 8.2.1 which were released today.
Actions