Project

General

Profile

Actions

Bug #2719

closed

Can't enter a reason for creating, cloning or deleting a group

Added by Jonathan CLARKE over 12 years ago. Updated over 12 years ago.

Status:
Released
Priority:
3
Assignee:
Jean VILVER
Category:
Web - Nodes & inventories
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When I change a Group, I can enter a "reason" message to explain why I changed it, but I can't do this when I create (via clicking "Create a new item" or by cloning an existing group), nor when I delete one.


Files

Actions #1

Updated by Jonathan CLARKE over 12 years ago

  • Category set to Web - Nodes & inventories

Updated by Jean VILVER over 12 years ago

In 5c2decebd00776cbe58929c203d4110e86d43c0, we can now enter a reason when deleting a group.

See attached image to see the screenshots before and after.

Actions #3

Updated by Jean VILVER over 12 years ago

  • Status changed from In progress to Discussion

Jonathan CLARKE wrote:

When I change a Group, I can enter a "reason" message to explain why I changed it, but I can't do this when I create (via clicking "Create a new item" or by cloning an existing group), nor when I delete one.

We can enter a reason while creating or cloning only for a directive.

Do we want generalize that for every element that can be created or cloned (i.e. group, and rule)?

Actions #4

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 2.4.0~beta4 to 2.4.0~beta3

Jean VILVER wrote:

Jonathan CLARKE wrote:

When I change a Group, I can enter a "reason" message to explain why I changed it, but I can't do this when I create (via clicking "Create a new item" or by cloning an existing group), nor when I delete one.

We can enter a reason while creating or cloning only for a directive.

Do we want generalize that for every element that can be created or cloned (i.e. group, and rule)?

Yes! This should be the same everywhere.

Actions #5

Updated by Nicolas PERRON over 12 years ago

What's about this issue, Jean ?
Are you still working on it ?

Actions #6

Updated by Jean VILVER over 12 years ago

  • Status changed from Discussion to In progress
  • Target version changed from 2.4.0~beta3 to 2.4.0~beta4

I think we should move this task in beta4 for now. It won't make it in beta3.

Actions #7

Updated by Nicolas PERRON over 12 years ago

Jean VILVER wrote:

I think we should move this task in beta4 for now. It won't make it in beta3.

OK, but we still need a Technical Review

Actions #8

Updated by Vincent MEMBRÉ over 12 years ago

for what was done in beta3, it looks nice!

Actions #10

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 2.4.0~beta4 to 2.4.0~beta5
Actions #11

Updated by Jean VILVER over 12 years ago

  • Assignee changed from Jean VILVER to Jonathan CLARKE

Jon, can you describe the workflow that you want when creating and cloning a group?

Actions #12

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 2.4.0~beta5 to 2.4.0~rc1
Actions #13

Updated by Jonathan CLARKE over 12 years ago

  • Assignee changed from Jonathan CLARKE to Jean VILVER

Jean VILVER wrote:

Jon, can you describe the workflow that you want when creating and cloning a group?

I suggest that you simply add the "Please enter a message explaining the reason for this change." section to the group/category creation popup, with the same validation rules as elsewhere.

Actions #14

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 2.4.0~rc1 to 2.4.0~rc2
Actions #15

Updated by Nicolas PERRON over 12 years ago

  • Target version changed from 2.4.0~rc2 to 2.4.0~rc1
Actions #16

Updated by Jean VILVER over 12 years ago

In 2b239d81caa3f76a13d45e22eb7130db97568252:
- we can add a reason field when cloning a group

See image attached.

Actions #17

Updated by Jean VILVER over 12 years ago

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100
Actions #18

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 2.4.0~rc1 to 2.4.0~beta5
Actions #19

Updated by Jean VILVER over 12 years ago

In 0c594586cdd70352433c4bd2785848a3e7bf63fa
- we can add a reason field when creating a group.

See image attached.

Actions #20

Updated by François ARMAND over 12 years ago

The code is OK, but #2921 will have to be addressed before final release.

Actions #21

Updated by François ARMAND over 12 years ago

  • Status changed from Pending technical review to Released
Actions

Also available in: Atom PDF