Project

General

Profile

Actions

Bug #2719

closed

Can't enter a reason for creating, cloning or deleting a group

Bug #2719: Can't enter a reason for creating, cloning or deleting a group

Added by Jonathan CLARKE over 13 years ago. Updated about 13 years ago.

Status:
Released
Priority:
3
Assignee:
Jean VILVER
Category:
Web - Nodes & inventories
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When I change a Group, I can enter a "reason" message to explain why I changed it, but I can't do this when I create (via clicking "Create a new item" or by cloning an existing group), nor when I delete one.


Files

Updated by Jonathan CLARKE over 13 years ago Actions #1

  • Category set to Web - Nodes & inventories

Updated by Jean VILVER over 13 years ago Actions #2

reason_delete_group_before.png
reason_delete_group_after.png

In 5c2decebd00776cbe58929c203d4110e86d43c0, we can now enter a reason when deleting a group.

See attached image to see the screenshots before and after.

Updated by Jean VILVER over 13 years ago Actions #3

  • Status changed from In progress to Discussion

Jonathan CLARKE wrote:

When I change a Group, I can enter a "reason" message to explain why I changed it, but I can't do this when I create (via clicking "Create a new item" or by cloning an existing group), nor when I delete one.

We can enter a reason while creating or cloning only for a directive.

Do we want generalize that for every element that can be created or cloned (i.e. group, and rule)?

Updated by Jonathan CLARKE over 13 years ago Actions #4

  • Target version changed from 2.4.0~beta4 to 2.4.0~beta3

Jean VILVER wrote:

Jonathan CLARKE wrote:

When I change a Group, I can enter a "reason" message to explain why I changed it, but I can't do this when I create (via clicking "Create a new item" or by cloning an existing group), nor when I delete one.

We can enter a reason while creating or cloning only for a directive.

Do we want generalize that for every element that can be created or cloned (i.e. group, and rule)?

Yes! This should be the same everywhere.

Updated by Nicolas PERRON over 13 years ago Actions #5

What's about this issue, Jean ?
Are you still working on it ?

Updated by Jean VILVER over 13 years ago Actions #6

  • Status changed from Discussion to In progress
  • Target version changed from 2.4.0~beta3 to 2.4.0~beta4

I think we should move this task in beta4 for now. It won't make it in beta3.

Updated by Nicolas PERRON over 13 years ago Actions #7

Jean VILVER wrote:

I think we should move this task in beta4 for now. It won't make it in beta3.

OK, but we still need a Technical Review

Updated by Vincent MEMBRÉ over 13 years ago Actions #8

for what was done in beta3, it looks nice!

Updated by Jonathan CLARKE about 13 years ago Actions #10

  • Target version changed from 2.4.0~beta4 to 2.4.0~beta5

Updated by Jean VILVER about 13 years ago Actions #11

  • Assignee changed from Jean VILVER to Jonathan CLARKE

Jon, can you describe the workflow that you want when creating and cloning a group?

Updated by Jonathan CLARKE about 13 years ago Actions #12

  • Target version changed from 2.4.0~beta5 to 2.4.0~rc1

Updated by Jonathan CLARKE about 13 years ago Actions #13

  • Assignee changed from Jonathan CLARKE to Jean VILVER

Jean VILVER wrote:

Jon, can you describe the workflow that you want when creating and cloning a group?

I suggest that you simply add the "Please enter a message explaining the reason for this change." section to the group/category creation popup, with the same validation rules as elsewhere.

Updated by Jonathan CLARKE about 13 years ago Actions #14

  • Target version changed from 2.4.0~rc1 to 2.4.0~rc2

Updated by Nicolas PERRON about 13 years ago Actions #15

  • Target version changed from 2.4.0~rc2 to 2.4.0~rc1

Updated by Jean VILVER about 13 years ago Actions #16

clone_group_after_with_reason.png

In 2b239d81caa3f76a13d45e22eb7130db97568252:
- we can add a reason field when cloning a group

See image attached.

Updated by Jean VILVER about 13 years ago Actions #17

  • Status changed from In progress to Pending technical review
  • % Done changed from 0 to 100

Updated by Jonathan CLARKE about 13 years ago Actions #18

  • Target version changed from 2.4.0~rc1 to 2.4.0~beta5

Updated by Jean VILVER about 13 years ago Actions #19

create_a_new_item_with_reason.png

In 0c594586cdd70352433c4bd2785848a3e7bf63fa
- we can add a reason field when creating a group.

See image attached.

Updated by François ARMAND about 13 years ago Actions #20

The code is OK, but #2921 will have to be addressed before final release.

Updated by François ARMAND about 13 years ago Actions #21

  • Status changed from Pending technical review to Released
Actions

Also available in: PDF Atom