Actions
Architecture #2775
closedCommon promises have redondant classes definition about root server and policy server
Status:
Resolved
Priority:
1 (highest)
Assignee:
-
Category:
System techniques
Target version:
Pull Request:
Effort required:
Name check:
Fix check:
Regression:
Description
Since #2687 , the common promises have redondant definition of classes. Extract from common/1.0/promises.st:
[...] bundle common va { [...] # definition of the machine roles &NODEROLE& } bundle common rudder_roles { classes: # Abort if no uuid is defined "should_not_continue" not => fileexists("${g.uuid_file}"); # Policy Server is a machine which delivers promises "policy_server" expression => strcmp("root","$(g.uuid)"); # Root Server is the top policy server machine "root_server" expression => strcmp("root","$(g.uuid)"); } [...]
And as said the #2687 issue:
&NODEROLE& can contains:
On the root server :
classes: "policy_server" expression => "any"; "root_server" expression => "any";
On a relay server
classes: "policy_server" expression => "any";
or on a simple Node
# This node doesn't have any specific roleInto the initial promises, the &NODEROLE& part doesn't exist. It seems that there is two choices:
- Remove &NODEROLE& which became obsolete.
- Remove classes defined without &NODEROLE& in order to let them exist only for initial promises.
No matter what choice is made, the definition of relay server is not enough elaborated.
Actions