User story #2866
closedImprove Event logs table
Files
Updated by Jean VILVER over 12 years ago
- File event_logs_table_character_pagination.png event_logs_table_character_pagination.png added
- File event_logs_table_word_pagination.png event_logs_table_word_pagination.png added
- Status changed from New to In progress
- Assignee changed from Jean VILVER to Jonathan CLARKE
I've work on this ticket, and I have two options to solve it.
If you want to try other options just tell me, I'll add more.
(Note that the solution we'll be use on every tables.)
Option 1 :
Option 2 :
Updated by Jonathan CLARKE over 12 years ago
- Assignee changed from Jonathan CLARKE to Jean VILVER
Jean VILVER wrote:
I've work on this ticket, and I have two options to solve it.
If you want to try other options just tell me, I'll add more.
(Note that the solution we'll be use on every tables.)
Option 1 :
Option 1 is OK for me, so long as there are tooltips above the arrows (<<, <, > and >>) that say "First", "Previous", "Next" and "Last". If this is not possible, we must stick with option 2, but I'm sure you can add some tooltips :)
Updated by Jonathan CLARKE over 12 years ago
- Target version changed from 2.4.0~rc1 to 2.4.0~rc2
Updated by Jean VILVER over 12 years ago
I've tried to find an example with this behavior but I couldn't.
Still, I tried to implement it but, it's not an easy task. I think that I have to alter the dataTable plugin to generate a different html code, in order to use the tooltips that we use in other parts of rudder.
So, I guess we should go with option 2, but maybe with a better presentation : the table on the home page of http://datatables.net/.
Should I go with option 2 or with a better option 2 ?
Updated by Jean VILVER over 12 years ago
- Assignee changed from Jean VILVER to Jonathan CLARKE
Updated by Jonathan CLARKE over 12 years ago
- Assignee changed from Jonathan CLARKE to Jean VILVER
Jean VILVER wrote:
I've tried to find an example with this behavior but I couldn't.
Still, I tried to implement it but, it's not an easy task. I think that I have to alter the dataTable plugin to generate a different html code, in order to use the tooltips that we use in other parts of rudder.
So, I guess we should go with option 2, but maybe with a better presentation : the table on the home page of http://datatables.net/.
Should I go with option 2 or with a better option 2 ?
Agreed. If you can do "better option 2" quickly and easily, then go for it :)
Updated by Jean VILVER over 12 years ago
The result :
before:
after:
Updated by Jean VILVER over 12 years ago
Updated by Jean VILVER over 12 years ago
- Status changed from In progress to Pending technical review
Updated by Jean VILVER over 12 years ago
- Status changed from Pending technical review to In progress
In event_logs_improve_after.png, we can see a border-left on every cell of the table, I'm removing this border.
Plus, the width of the columns change when we click on the table headers in order to sort the table's lines. This behavior can be annoying. It's much better to have a fixed column width while sorting.
Updated by Jean VILVER over 12 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 0 to 100
Applied in changeset 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce.
Updated by Jean VILVER over 12 years ago
Changes in 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce:
- The border-left on every cell is removed
- While sorting lines, the column width is not affected (except when the table has a small width, which happens when the window width is small)
The result:
Updated by Jean VILVER over 12 years ago
Note: I've accidentally squashed the improve of the rules table in 75bcca2a187727d72a34bc2a4484ef1def927c4a.
Updated by Nicolas CHARLES over 12 years ago
- Status changed from Pending technical review to 10
This looks valid, thank you Jean.
The sDom option of datatables looks very convenient
Updated by Nicolas PERRON over 12 years ago
- Target version changed from 2.4.0~rc2 to 2.4.0~beta5
Updated by Nicolas CHARLES over 12 years ago
- Status changed from 10 to In progress
- % Done changed from 100 to 80
I'm reverting my technical review agreement.
Jean, one should never change the content of ui-lightness, lest we can't upgrade to newer version of jquery/jquery-ui without breaking stuffs
Could you please do all the necessary modification to reverts or amends commit 038b1dffb6f74936456d0f32dd68c698c3269e03, fc330192a7aba5bb039fbff5472d9046e8a679ec, ccfb0cd9e8227d09a4b7f4d3eddb8a1b0ea856a1, 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce (which are linked to ticket #2669, and this ticket) so that the ui-lightness theme is restored to its initial state, and move the modification to the jquery-rudder-bridge.css ?
Updated by Jean VILVER over 12 years ago
- Status changed from In progress to Pending technical review
Nicolas CHARLES wrote:
[...]
Could you please do all the necessary modification to reverts or amends commit 038b1dffb6f74936456d0f32dd68c698c3269e03, fc330192a7aba5bb039fbff5472d9046e8a679ec, ccfb0cd9e8227d09a4b7f4d3eddb8a1b0ea856a1, 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce (which are linked to ticket #2669, and this ticket) so that the ui-lightness theme is restored to its initial state, and move the modification to the jquery-rudder-bridge.css ?
Updated by Nicolas CHARLES over 12 years ago
- Status changed from Pending technical review to 10
- % Done changed from 80 to 100
Thank you Jean, this seems valid
Updated by Jonathan CLARKE over 12 years ago
- Status changed from 10 to Released