Architecture #3028
closed
Make the CFEngine process checking promise in Rudder more clean and targeted
Added by Matthieu CERDA almost 12 years ago.
Updated almost 12 years ago.
Category:
System techniques
Description
Make the CFEngine process checking promise in Rudder more clean and targeted.
As of now, this promise contains a lot of code duplication, and targets ALL the CFEngine processes (even the currently running one.)
We should avoid this and make it more clean.
Pull request linked to this US: https://github.com/Normation/rudder-techniques/pull/4
Files
- Description updated (diff)
- Status changed from New to Pending technical review
- % Done changed from 0 to 100
Pull request available, to be reviewed.
I removed the feature Jon was talking about in the diff (the process_select), but this feature also applies to this user story as well. Should I add a subtask to this ticket ?
Enclosed to this comment is the patch to apply this new feature, for easier review and applying later.
- Status changed from Pending technical review to 10
The pull request has been merged
- Status changed from 10 to Released
- Tracker changed from User story to Architecture
- Status changed from Released to Pending release
Matthieu CERDA wrote:
I removed the feature Jon was talking about in the diff (the process_select), but this feature also applies to this user story as well. Should I add a subtask to this ticket ?
Enclosed to this comment is the patch to apply this new feature, for easier review and applying later.
No, this is a different change. Please create a new ticket and explain the logic behind your suggestion (and make a pull request with the patch, of course :) )
- Target version changed from 2.4.0~rc2 to 2.5.0~beta1
This was NOT on 2.4 branch, but on master! Please pay attention to target versions...
- Status changed from Pending release to Released
Also available in: Atom
PDF
Updated by Matthieu CERDA 
Updated by 
Updated by Jonathan CLARKE