Project

General

Profile

Actions

Bug #3245

closed

Techniques "Process Management" and "Set permissions on files": Wrong merge resulting in "policyInstanceId" variables in "Process Management" and "Set permissions on files"

Added by Nicolas PERRON almost 10 years ago. Updated almost 8 years ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Regression:

Description

It seems that a wrong merge between branch 2.3 and 2.4 has result in presence of "policyInstanceId" variables in the new versions of the Techniques "Process Management" and "Set permissions on files".

Pull Request URL: https://github.com/Normation/rudder-techniques/pull/52

Actions #1

Updated by Nicolas PERRON almost 10 years ago

  • Assignee set to Nicolas PERRON
Actions #2

Updated by Nicolas PERRON almost 10 years ago

  • Description updated (diff)
Actions #3

Updated by Nicolas PERRON almost 10 years ago

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100
Actions #4

Updated by Nicolas PERRON almost 10 years ago

  • Assignee changed from Nicolas PERRON to Jonathan CLARKE

Jon, could you review the pull request, please ?

Actions #5

Updated by Jonathan CLARKE almost 10 years ago

Nicolas PERRON wrote:

Jon, could you review the pull request, please ?

Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.

Actions #6

Updated by Nicolas PERRON almost 10 years ago

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jon, could you review the pull request, please ?

Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.

I didn't notice any impact for user and in the code, it seems logic that it has no impact. In fact this is more a refactoring than a bug.

Actions #7

Updated by Jonathan CLARKE almost 10 years ago

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jon, could you review the pull request, please ?

Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.

I didn't notice any impact for user and in the code, it seems logic that it has no impact. In fact this is more a refactoring than a bug.

OK that makes sense. Thanks for clarifying. I'll merge the PR.

Actions #8

Updated by Nicolas PERRON almost 10 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:0b207ae98598527aa4fde4f7bf20fe391e617435.

Actions #9

Updated by Jonathan CLARKE almost 10 years ago

Applied in changeset commit:82e512275574333afb68da1ae5942757c09ce433.

Actions #10

Updated by Nicolas PERRON almost 10 years ago

  • Status changed from Pending release to Released
Actions #11

Updated by Benoît PECCATTE almost 8 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions

Also available in: Atom PDF