Project

General

Profile

Actions
Copy link

Bug #3245

closed

Techniques "Process Management" and "Set permissions on files": Wrong merge resulting in "policyInstanceId" variables in "Process Management" and "Set permissions on files"

Bug #3245: Techniques "Process Management" and "Set permissions on files": Wrong merge resulting in "policyInstanceId" variables in "Process Management" and "Set permissions on files"

Added by Nicolas PERRON almost 13 years ago. Updated almost 11 years ago.

Status:
Released
Priority:
N/A
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
2.4.4
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

It seems that a wrong merge between branch 2.3 and 2.4 has result in presence of "policyInstanceId" variables in the new versions of the Techniques "Process Management" and "Set permissions on files".

Pull Request URL: https://github.com/Normation/rudder-techniques/pull/52

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #1

  • Assignee set to Nicolas PERRON

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #2

  • Description updated (diff)

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #3

  • Status changed from New to Pending technical review
  • % Done changed from 0 to 100

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #4

  • Assignee changed from Nicolas PERRON to Jonathan CLARKE

Jon, could you review the pull request, please ?

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
 #5

Nicolas PERRON wrote:

Jon, could you review the pull request, please ?

Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #6

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jon, could you review the pull request, please ?

Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.

I didn't notice any impact for user and in the code, it seems logic that it has no impact. In fact this is more a refactoring than a bug.

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
 #7

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jon, could you review the pull request, please ?

Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.

I didn't notice any impact for user and in the code, it seems logic that it has no impact. In fact this is more a refactoring than a bug.

OK that makes sense. Thanks for clarifying. I'll merge the PR.

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
 #8

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:0b207ae98598527aa4fde4f7bf20fe391e617435.

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
 #9

Applied in changeset commit:82e512275574333afb68da1ae5942757c09ce433.

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
 #10

  • Status changed from Pending release to Released

Updated by Benoît PECCATTE almost 11 years ago Actions
Copy link
 #11

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions
Copy link

Also available in: PDF Atom