Project

General

Profile

Actions

Bug #3681

closed

Double cron job for Rudder agent when upgrading from 2.5 to 2.6

Added by Dennis Cabooter over 9 years ago. Updated almost 8 years ago.

Status:
Released
Priority:
2
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Regression:

Description

After upgrading from 2.5 to 2.6 a new cron file is created. However, the old cron entry is not cleaned up. This happens on either Ubuntu (12.04 LTS) and Red Hat (RHEL 5).

# tail -1 /etc/crontab
0,5,10,15,20,25,30,35,40,45,50,55 * * * * root if [ ! -e /opt/rudder/etc/disable-agent -a `ps -efww | grep -E "(cf-execd|cf-agent)" | grep -E "/var/rudder/cfengine-community/bin/(cf-execd|cf-agent)" | grep -v grep | wc -l` -eq 0 ]; then /var/rudder/cfengine-community/bin/cf-agent -f failsafe.cf \&\& /var/rudder/cfengine-community/bin/cf-agent; fi
# tail -1 /etc/cron.d/rudder-agent 
0,5,10,15,20,25,30,35,40,45,50,55 * * * * root if [ ! -e /opt/rudder/etc/disable-agent -a `ps -efww | grep -E "(cf-execd|cf-agent)" | grep -E "/var/rudder/cfengine-community/bin/(cf-execd|cf-agent)" | grep -v grep | wc -l` -eq 0 ]; then /var/rudder/cfengine-community/bin/cf-agent -f failsafe.cf && /var/rudder/cfengine-community/bin/cf-agent; fi
Actions #1

Updated by Nicolas CHARLES over 9 years ago

ouch,
on the crontab line you have \&\&, which is not really great... much come from an older bug.

Actions #2

Updated by Nicolas CHARLES over 9 years ago

  • Assignee set to Nicolas PERRON
  • Priority changed from N/A to 2
  • Target version set to 2.5.5

Nicolas, could you correct the cleanup in the process_matching.st in the common technique ?
it seems that there is no proper deletion of the lines with \
Note : the correction must be done on 2.5

Thanks !

Actions #3

Updated by Nicolas CHARLES over 9 years ago

  • Project changed from 34 to 24
Actions #4

Updated by Nicolas CHARLES over 9 years ago

  • Category set to Techniques
Actions #5

Updated by Nicolas PERRON over 9 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas PERRON to Nicolas CHARLES
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/142

Done.
Pull Request URL added: https://github.com/Normation/rudder-techniques/pull/142

Nicolas, could you review it, please ?

Actions #6

Updated by Nicolas PERRON over 9 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:aae4df9f22bfef54abd265e4d6886c350c57d8a0.

Actions #7

Updated by Nicolas CHARLES over 9 years ago

Applied in changeset commit:dcce09ba55d5dedfc4b2dd08e6cdba7f9dcd11cb.

Actions #8

Updated by Nicolas PERRON over 9 years ago

  • Subject changed from Double cron job when upgrading from 2.5 to 2.6 to Double cron job for Rudder agent when upgrading from 2.5 to 2.6
Actions #9

Updated by Nicolas PERRON over 9 years ago

  • Status changed from Pending release to Released
Actions #10

Updated by Nicolas PERRON over 9 years ago

This bug has been fixed in Rudder 2.5.5, which was released today.
Check out:

Actions #11

Updated by Benoît PECCATTE almost 8 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions

Also available in: Atom PDF