Rudder

Pull Request URL added: https://github.com/Normation/rudder-packages/pull/94

Jon, could you review it please ?

Jonathan CLARKE wrote:

Can you please clarify what version are affected by this? This is a migration script, so what are the conditions on the old and new versions (migrating from and to)?

On affect all versions:

• history.inventories.enable is added into /opt/rudder/etc/rudder-web.properties if not present despite the fact that it should be added only into /opt/rudder/etc/inventory-web.conf

• 'ldap.inventories.removed.basedn need to be added in both /opt/rudder/etc/rudder-web.properties (this is already the case) and /opt/rudder/etc/inventory-web.conf (this is never the case)
• This property exists since Rudder 2.4.0~alpha7

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Can you please clarify what version are affected by this? This is a migration script, so what are the conditions on the old and new versions (migrating from and to)?

On affect all versions:

• history.inventories.enable is added into /opt/rudder/etc/rudder-web.properties if not present despite the fact that it should be added only into /opt/rudder/etc/inventory-web.conf

Right, but there is no impact from adding an excessive property. What about versions where it is not in the provided config file, but should be added by this migration? What versions are they?

The other affect only a Rudder existing since 2.3:

• 'ldap.inventories.removed.basedn need to be added in both /opt/rudder/etc/rudder-web.properties (this is already the case) and /opt/rudder/etc/inventory-web.conf (this is never the case)
• This property exists since Rudder 2.4.0~alpha7

OK, so depending on your answer to the above question, this would only affect users migrating from the now deprecated 2.3?

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Can you please clarify what version are affected by this? This is a migration script, so what are the conditions on the old and new versions (migrating from and to)?

On affect all versions:

• history.inventories.enable is added into /opt/rudder/etc/rudder-web.properties if not present despite the fact that it should be added only into /opt/rudder/etc/inventory-web.conf

Right, but there is no impact from adding an excessive property. What about versions where it is not in the provided config file, but should be added by this migration? What versions are they?

The other affect only a Rudder existing since 2.3:

• 'ldap.inventories.removed.basedn need to be added in both /opt/rudder/etc/rudder-web.properties (this is already the case) and /opt/rudder/etc/inventory-web.conf (this is never the case)
• This property exists since Rudder 2.4.0~alpha7

OK, so depending on your answer to the above question, this would only affect users migrating from the now deprecated 2.3?

• These properties appears since 2.4.0 then, it affectes only users before 2.4.
• The impact is: Rudder could not be started if these properties are not added into the file /opt/rudder/etc/inventory-web.conf
• And you're right, excessive property has no impact

Cool. Please clarify the bug's title based on this informaton, to make it understandable by users potentially affected by this.

Since this only affects users migrating from 2.3, which is now deprecated, I don't see this as high priority. Let's fix it anyway (why not be nice when we can?), but no rush to push out a new version IMHO. Do you agree?

Jonathan CLARKE wrote:

Cool. Please clarify the bug's title based on this informaton, to make it understandable by users potentially affected by this.

Since this only affects users migrating from 2.3, which is now deprecated, I don't see this as high priority. Let's fix it anyway (why not be nice when we can?), but no rush to push out a new version IMHO. Do you agree?

I agree

Applied in changeset commit:f4ee1a52c8613fc2ad37b9290ec2bb41d8a43bc0.

This bug has been fixed in Rudder 2.4.8, which was released today.
Check out:

• The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2013-September/000044.html
• The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog24
• Download information: http://www.rudder-project.org/foswiki/Download/