Project

General

Profile

Actions
Copy link

Bug #3810

closed

The properties 'history.inventories.enable' and 'ldap.inventories.removed.basedn' are missing the /opt/rudder/etc/inventory-web after a migration from Rudder 2.3 and 'history.inventories.enable' is uslessly added into /opt/rudder/etc/rudder-web.properties

Added by Nicolas PERRON over 11 years ago. Updated over 9 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Jonathan CLARKE
Category:
Packaging
Target version:
2.4.8
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The migration script rudder-upgrade add some new properties for each major version but since Rudder 2.4, the add of two properties are wrongly made.

history.inventories.enable should be add in /opt/rudder/etc/inventory-web.conf

ldap.inventories.removed.basedn should be add in /opt/rudder/etc/inventory-web.conf and /opt/rudder/etc/inventory-web.conf

Actions
Copy link
 #1

Updated by Nicolas PERRON over 11 years ago

These changes was made by #2422 and #2790

Actions
Copy link
 #2

Updated by Nicolas PERRON over 11 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/94

Pull Request URL added: https://github.com/Normation/rudder-packages/pull/94

Jon, could you review it please ?

Actions
Copy link
 #3

Updated by Jonathan CLARKE over 11 years ago

Can you please clarify what version are affected by this? This is a migration script, so what are the conditions on the old and new versions (migrating from and to)?

Actions
Copy link
 #4

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Nicolas PERRON
Actions
Copy link
 #5

Updated by Nicolas PERRON over 11 years ago

  • Assignee changed from Nicolas PERRON to Jonathan CLARKE

Jonathan CLARKE wrote:

Can you please clarify what version are affected by this? This is a migration script, so what are the conditions on the old and new versions (migrating from and to)?

On affect all versions:

  • history.inventories.enable is added into /opt/rudder/etc/rudder-web.properties if not present despite the fact that it should be added only into /opt/rudder/etc/inventory-web.conf
The other affect only a Rudder existing since 2.3:
  • 'ldap.inventories.removed.basedn need to be added in both /opt/rudder/etc/rudder-web.properties (this is already the case) and /opt/rudder/etc/inventory-web.conf (this is never the case)
  • This property exists since Rudder 2.4.0~alpha7
Actions
Copy link
 #6

Updated by Jonathan CLARKE over 11 years ago

  • Assignee changed from Jonathan CLARKE to Nicolas PERRON

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Can you please clarify what version are affected by this? This is a migration script, so what are the conditions on the old and new versions (migrating from and to)?

On affect all versions:

  • history.inventories.enable is added into /opt/rudder/etc/rudder-web.properties if not present despite the fact that it should be added only into /opt/rudder/etc/inventory-web.conf

Right, but there is no impact from adding an excessive property. What about versions where it is not in the provided config file, but should be added by this migration? What versions are they?

The other affect only a Rudder existing since 2.3:
  • 'ldap.inventories.removed.basedn need to be added in both /opt/rudder/etc/rudder-web.properties (this is already the case) and /opt/rudder/etc/inventory-web.conf (this is never the case)
  • This property exists since Rudder 2.4.0~alpha7

OK, so depending on your answer to the above question, this would only affect users migrating from the now deprecated 2.3?

Actions
Copy link
 #7

Updated by Nicolas PERRON over 11 years ago

  • Assignee changed from Nicolas PERRON to Jonathan CLARKE

Jonathan CLARKE wrote:

Nicolas PERRON wrote:

Jonathan CLARKE wrote:

Can you please clarify what version are affected by this? This is a migration script, so what are the conditions on the old and new versions (migrating from and to)?

On affect all versions:

  • history.inventories.enable is added into /opt/rudder/etc/rudder-web.properties if not present despite the fact that it should be added only into /opt/rudder/etc/inventory-web.conf

Right, but there is no impact from adding an excessive property. What about versions where it is not in the provided config file, but should be added by this migration? What versions are they?

The other affect only a Rudder existing since 2.3:
  • 'ldap.inventories.removed.basedn need to be added in both /opt/rudder/etc/rudder-web.properties (this is already the case) and /opt/rudder/etc/inventory-web.conf (this is never the case)
  • This property exists since Rudder 2.4.0~alpha7

OK, so depending on your answer to the above question, this would only affect users migrating from the now deprecated 2.3?

  • These properties appears since 2.4.0 then, it affectes only users before 2.4.
  • The impact is: Rudder could not be started if these properties are not added into the file /opt/rudder/etc/inventory-web.conf
  • And you're right, excessive property has no impact
Actions
Copy link
 #8

Updated by Jonathan CLARKE over 11 years ago

  • Assignee changed from Jonathan CLARKE to Nicolas PERRON
  • Priority changed from 1 (highest) to 4

Cool. Please clarify the bug's title based on this informaton, to make it understandable by users potentially affected by this.

Since this only affects users migrating from 2.3, which is now deprecated, I don't see this as high priority. Let's fix it anyway (why not be nice when we can?), but no rush to push out a new version IMHO. Do you agree?

Actions
Copy link
 #9

Updated by Nicolas PERRON over 11 years ago

  • Subject changed from The add of properties 'history.inventories.enable' should be made in /opt/rudder/etc/inventory-web.conf instead of /opt/rudder/etc/rudder-web.properties and 'ldap.inventories.removed.basedn' in both files to The properties 'history.inventories.enable' and 'ldap.inventories.removed.basedn' are missing the /opt/rudder/etc/inventory-web after a migration from Rudder 2.3 and 'history.inventories.enable' is uslessly added into /opt/rudder/etc/rudder-web.properties
  • Assignee changed from Nicolas PERRON to Jonathan CLARKE
  • Priority changed from 4 to 1 (highest)

Jonathan CLARKE wrote:

Cool. Please clarify the bug's title based on this informaton, to make it understandable by users potentially affected by this.

Since this only affects users migrating from 2.3, which is now deprecated, I don't see this as high priority. Let's fix it anyway (why not be nice when we can?), but no rush to push out a new version IMHO. Do you agree?

I agree

Actions
Copy link
 #10

Updated by Nicolas PERRON over 11 years ago

  • Status changed from Discussion to Pending release

Applied in changeset commit:f4ee1a52c8613fc2ad37b9290ec2bb41d8a43bc0.

Actions
Copy link
 #11

Updated by Jonathan CLARKE over 11 years ago

Applied in changeset commit:054ba22eec531bc88c94c4d3a1ddc57137dd1ba5.

Actions
Copy link
 #12

Updated by Nicolas PERRON about 11 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.4.8, which was released today.
Check out:

Actions
Copy link
 #13

Updated by Benoît PECCATTE over 9 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions
Copy link

Also available in: Atom PDF