Bug #3958
closed
Available options for rudder.batch.reportscleaner.frequency are not documented in rudder-web.properties (migration script)
Description
Since we added a new commentary to rudder-web.properties for property rudder.batch.reportscleaner.frequency (see #3940) we need to modify the migration script to take this modification into account.
We have to add :
# Available options: hourly, daily, weekly
We also need another update script to add this line if it is missing.
Updated by Vincent MEMBRÉ about 11 years ago
- Target version changed from 2.8.0~beta1 to 2.6.6
Updated by Vincent MEMBRÉ about 11 years ago
- Status changed from New to Pending technical review
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
- Pull Request set to https://github.com/Normation/rudder-packages/pull/125
Pull request here : https://github.com/Normation/rudder-packages/pull/125
Updated by Jonathan CLARKE about 11 years ago
- Status changed from Pending technical review to Rejected
Thanks for doing this Vincent, but I think it is not necessary. Adding a 4-5 line migration script to add a comment in the config file is overly zealous, and actually introduce more risk of affecting this version's stability than not doing it - it a bug is in the migration script (I'm not saying there is one, just that it could easily happen) we would future upgrades, and adding a comment is not a valid reason to do this.
I'm happy to just have this comment added to new installations of Rudder.