Project

General

Profile

Bug #4040

Remove comma after the promiser from passwordCheck in the distirbutePolicy promises

Added by Nicolas PERRON over 6 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
1
Category:
Techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

A comma after promiser remains from the fix of #3871 which will prevent Rudder server to regenerate its promises on Rudder 2.8


Related issues

Related to Rudder - User story #3869: Integration of CFEngine 3.5.* into RudderReleased2013-10-03Actions
Related to Rudder - Bug #4042: Remove comma after the promiser from passwordCheck in the distirbutePolicy inital promisesReleased2013-10-10Actions

Associated revisions

Revision e2afbeda (diff)
Added by Nicolas PERRON over 6 years ago

Fixes #4040 - Remove the comma after promiser which check the password of PostgreSQL

Revision 6250d63e
Added by Jonathan CLARKE over 6 years ago

Merge pull request #210 from nperron/bug_4040/dev/remove_comma_after_promiser_in_passwordcheck

Fixes #4040 - Remove the comma after promiser which check the password of PostgreSQL

History

#1

Updated by Nicolas PERRON over 6 years ago

  • Project changed from packages to Techniques
#2

Updated by Nicolas PERRON over 6 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas PERRON to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/210

The consequence will be that the migration to Rudder 2.8 will only be possible from Rudder 2.4.12, 2.6.9 and 2.7.6...

Pull Request URL added: https://github.com/Normation/rudder-techniques/pull/210

Jon, could you review it please ?

#3

Updated by Jonathan CLARKE over 6 years ago

Nicolas PERRON wrote:

The consequence will be that the migration to Rudder 2.8 will only be possible from Rudder 2.4.12, 2.6.9 and 2.7.6...

Erm, I'm not sure about that actually - this comma is in the distributePolicy Technique, which by definition is only used on the policy servers (and before 2.8, there could only be a single root policy server). So we don't have to worry about this "broken" promise being on nodes, because it can't be! So in effect, when a Rudder root server is upgraded, the system Techniques including distributePolicy will also be upgraded, and the promises regenerated! Easy :)

However, on the first run(s) of cf-agent, this might cause trouble, in the short period of time in between the rudder-agent upgrade to 3.5.* and the promise regeneration for the policy server. So I agree we should include this fix in older branches, but I don't think we need to change the upgrading procedure.

#4

Updated by Nicolas PERRON over 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:e2afbedaa9a4b44f0e8cb97e35ec7df028c81331.

#5

Updated by Jonathan CLARKE over 6 years ago

Applied in changeset commit:6250d63efb70ec3fbfab1e0578e66d021029f4d8.

#6

Updated by Nicolas PERRON over 6 years ago

This issue is linked to the integration of CFE 3.5 #3869

#7

Updated by Nicolas PERRON over 6 years ago

This change will require the same change one the initial promises: #4042

#8

Updated by Nicolas PERRON over 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.4.12 which was released today.
Check out:

#9

Updated by BenoƮt PECCATTE almost 5 years ago

  • Project changed from Techniques to Rudder
  • Category set to Techniques

Also available in: Atom PDF