Bug #4206: Incorrect English grammar in documentation - Rudder - Issue Tracker

Actions

Copy link

Bug #4206

closed

Incorrect English grammar in documentation

Added by Dennis Cabooter about 11 years ago. Updated almost 11 years ago.

Status:

Released

Priority:

N/A

Assignee:

Vincent MEMBRÉ

Category:

Web - UI & UX

Target version:

2.6.10

Pull Request:

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Some of the grammar within the Rudder web interface and the Rudder documentation isn't correct. I tried to locate the incorrect grammar in the code as well in the documentation.

Basicly the incorrect grammar comes down to:

- the word "informations" should be "information", since it's never plural
- It's "each component" or instead of "every components"
- It's "each element" instead of "each elements"
- It's "this information" instead of "these information", since these is used for the plural and "information" is always singular

https://github.com/Normation/rudder-doc/pull/37
https://github.com/Normation/rudder/pull/362

Actions

Copy link

Updated by François ARMAND about 11 years ago

Category set to Web - UI & UX
Status changed from New to In progress
Assignee set to François ARMAND

Assigning myself for the merging management.

Actions

Copy link

Updated by François ARMAND about 11 years ago

Thanks for the contribution.

Could you check if some of the correction are valid correction in earlier release (branches/rudder/2.4, branches/rudder/2.6, branches/rudder/2.7, branches/rudder/2.8, branches/rudder/2.9 ?)

And if so, create a new pull request for the correct branches ?

Thanks,

Actions

Copy link

Updated by Dennis Cabooter about 11 years ago

I think I already did that. If not, can you explain me how to do it?

Actions

Copy link

Updated by Vincent MEMBRÉ almost 11 years ago

Assignee changed from François ARMAND to Vincent MEMBRÉ
Target version set to 2.6.10

I'm reatargeting pull requests:

Dennis here is the command i ran:

# Get on branch I need to rebase
git checkout branches/rudder/2.6

# Checkout on new branch, so my code branches are still in synch with central repo
git checkout -b bug/4206/correct_english

# One cherry-pick for each, stating from the oldest commit
git cherry-pick <commit-hash> # got it using git log on your master branch

# Optionnal, I renamed the commit starting with: Refs #4206 so redmine will link the commit to that issue
git rebase -i branches/rudder/2.6 #option r for each file

Actions

Copy link