Bug #4424: Copy of file from a remote host does not work since recursion option is not tolerated for file by CFEngine - Rudder - Issue Tracker

Actions

Copy link

Bug #4424

closed

Copy of file from a remote host does not work since recursion option is not tolerated for file by CFEngine

Added by Nicolas PERRON almost 11 years ago. Updated over 2 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Jonathan CLARKE

Category:

Generic methods

Target version:

ncf-0.x

Pull Request:

https://github.com/Normation/ncf/pull/35

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

As for file_copy_from_local_source_recursion, the bundle file_copy_from_remote_source_recursion should check if the argument is a file or a directory in order to remove depth_search on files. This is not the case now and the result is that no file is copied.

Actions

Copy link

Updated by Nicolas PERRON almost 11 years ago

Status changed from New to Pending technical review
Assignee set to Jonathan CLARKE
% Done changed from 0 to 100
Pull Request set to https://github.com/Normation/ncf/pull/35

Pull Request URL added: https://github.com/Normation/ncf/pull/35

Jon, I've made a PR based on the same problem from file_copy_from_local_source_recursion, it should be an easy review.

Actions

Copy link

Updated by Nicolas PERRON almost 11 years ago

Nicolas PERRON wrote:

Pull Request URL added: https://github.com/Normation/ncf/pull/35

Jon, I've made a PR based on the same problem from file_copy_from_local_source_recursion, it should be an easy review.

It wasn't as easy as I thought but I've made an update. Jon or Nicolas, could you review it please ?

Actions

Copy link