Project

General

Profile

Bug #4554

Bug #4551: Initial logrotate configuration (from initial-promises) does not include recent fixes

Initial logrotate configuration (from initial-promises) does not apply delaycompress option

Added by Jonathan CLARKE about 6 years ago. Updated about 6 years ago.

Status:
Released
Priority:
2
Category:
System techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

As a result of fixing #4551 (logrotate configs were not synchronized between techniques and initial promises), on branch 2.6, we removed the fix for #3923 from the initial promises, which only applied to 2.8+.

This was detected by the automatic tests in the techniques repository.

This bug will restore missing functionality.

#1

Updated by Jonathan CLARKE about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/308

Matthieu, in Nicolas' absence, can you please review this?

#2

Updated by Jonathan CLARKE about 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:083045bab4cee7ce3bfdd1443cabd8160f4d3100.

#3

Updated by Matthieu CERDA about 6 years ago

Applied in changeset policy-templates:commit:991580109aeeb0c5ab2468deb9c26b05450ebd40.

#4

Updated by Vincent MEMBRÉ about 6 years ago

What about the ubuntu and rhel version of the logrotate configuration file ? they don't include the delaycompress either in 2.8+? should we add it too ?

#5

Updated by Matthieu CERDA about 6 years ago

The naming is poor, the the .suse logrotate is used on EL too, same goes for the Debian one which is used on Ubuntu. I think they should be renamed to avoid further confusion.

#6

Updated by Matthieu CERDA about 6 years ago

Correction, it is only for rhel. Ubuntu has a separate file indeed, you're right !

#7

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Discussion
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE

Since issue #4556 introduced the same problem on rhel logrotate configuration file, reopening this issue to fix it

#8

Updated by Matthieu CERDA about 6 years ago

  • Status changed from Discussion to In progress
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
#9

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/308 to https://github.com/Normation/rudder-techniques/pull/311
#10

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset policy-templates:commit:8eb18507b10a718336aabce1968f8cef7f8a9823.

#11

Updated by Matthieu CERDA about 6 years ago

Applied in changeset policy-templates:commit:134805723487bb8e4458ab5027464b28fe1777b8.

#12

Updated by Vincent MEMBRÉ about 6 years ago

  • Subject changed from Initial logrotate configuration (from initial-promises) does not include fix for #3923 to Initial logrotate configuration (from initial-promises) does not apply delaycompress option
#13

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.8.3, which was released today.
Check out:

Also available in: Atom PDF