Project

General

Profile

Actions
Copy link

Bug #4565

closed

User story #4459: Support Rudder agent on AIX 5.3+

With older versions of rpm, boolean tests on macros fail if not quoted

Added by Jonathan CLARKE over 10 years ago. Updated over 10 years ago.

Status:
Released
Priority:
N/A
Assignee:
Matthieu CERDA
Category:
System integration
Target version:
2.10.0~beta1
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

For example, given this line in a .spec file:

%if %{is_tokyocabinet_here} == "false"

We can get this error:

21:43:01 undefined identifier
21:43:01 /usr/src/packages/SPECS/rudder-agent.spec:190: parseExpressionBoolean returns -1

Quoting the macro solves the problem. It will not be expanded, and we will end up with a string containing literally "%{is_tokyocabinet_here}", but that's fine because the test will fail.

Fixing.

Actions
Copy link
 #1

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA
Actions
Copy link
 #2

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:246d1207ebaa2b936d697888e56df5f98495f01a.

Actions
Copy link
 #3

Updated by Matthieu CERDA over 10 years ago

Applied in changeset commit:76041115f9b7008d9f752a567734f1ecc4bd80bd.

Actions
Copy link
 #4

Updated by Christophe Nowicki over 10 years ago

Hi Girls,

%if 0%{?mymacro:1}
# ... %{mymacro} is defined
%else
# ... %{mymacro} is not defined
%endif

Take a look at : 

http://backreference.org/2011/09/17/some-tips-on-rpm-conditional-macros/

and 

https://fedoraproject.org/wiki/Packaging:DistTag#Conditionals

Best Regards,

Actions
Copy link
 #5

Updated by Jonathan CLARKE over 10 years ago

Thanks for the tip Christophe. I actually came across that same blog post, which is why I decided to use the "quoted" approach, because the RPM version on AIX is OLD... Long live support for old OS!

Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 10 years ago

  • Subject changed from With older versions of rpm, boolean tests on macros can fail if not quoted to With older versions of rpm, boolean tests on macros fail if not quoted
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ over 10 years ago

  • Project changed from 34 to Rudder
  • Category set to System integration
  • Parent task set to #4459
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.0~beta1, which was released today.
Check out:

The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2014-March/000084.html
    The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog210
    Download information: https://www.rudder-project.org/site/get-rudder/downloads/
Actions
Copy link

Also available in: Atom PDF