Project

General

Profile

Bug #4582

Last update detection is broken, causing cron remove cf_lock database and flood with emails every 5 minutes

Added by Nicolas CHARLES almost 5 years ago. Updated over 4 years ago.

Status:
Released
Priority:
2
Category:
System techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

Cron now floods with mail, saying

WARNING: The file /var/rudder/cfengine-community/last_successful_inputs_update is older than 10 minutes, the agent are probably stuck. Purging the TokyoCabinet lock file... Done

Indeed du to a logical error, the file /var/rudder/cfengine-community/last_successful_inputs_update is updated only if the promises have actually been updated (and not only if the node could correctly connect to the node), resulting to a very often old /var/rudder/cfengine-community/last_successful_inputs_update file


Related issues

Related to Rudder - Bug #4604: Typo in the deletion of lock file if the promises are not updatedReleased2014-03-12
Related to Rudder - Bug #4752: cf_lock.tcdb is not cleaned by check-rudder-agent script when update file is older than 10 minutesReleased2014-04-11
Related to Rudder - Bug #4769: rudder-agent may be stucked by tokyo cabinet database bloatingReleased2014-04-23

Associated revisions

Revision 24db47ff (diff)
Added by Nicolas CHARLES almost 5 years ago

Fixes #4582: correct condition for last_successful_inputs_update timestamp update

Revision 3b157e44
Added by Jonathan CLARKE almost 5 years ago

Merge pull request #315 from ncharles/bug_4582/dev/wring_update_date_for_last_successful_inputs_update

Fixes #4582: correct condition for last_successful_inputs_update timesta...

History

#2 Updated by Nicolas CHARLES almost 5 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/314

#3 Updated by Jonathan CLARKE almost 5 years ago

  • Target version changed from 2.8.4 to 2.6.12

This also needs fixing in 2.6.

#4 Updated by Nicolas CHARLES almost 5 years ago

  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/314 to https://github.com/Normation/rudder-techniques/pull/315

#5 Updated by Jonathan CLARKE almost 5 years ago

  • Subject changed from Cron floods with mail to Last update detection is broken, causing cron to flood with emails

#6 Updated by Nicolas CHARLES almost 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:24db47ff98e209cc4255a5a053465d6063b030b4.

#7 Updated by Jonathan CLARKE almost 5 years ago

Applied in changeset policy-templates:commit:3b157e44859ae84a264cbf6803f280fca0f2dc3b.

#8 Updated by Jonathan CLARKE almost 5 years ago

  • Subject changed from Last update detection is broken, causing cron to flood with emails to Last update detection is broken, causing cron remove cf_lock database and flood with emails every 5 minutes

#9 Updated by Alex Tkachenko almost 5 years ago

In addition it tries to delete the wrong file: ${CFE_DIR}/state/cf_lock.tdcb.lock (typo in the extension).
I would also change the message to read the agent is probably stuck

#10 Updated by Alex Tkachenko almost 5 years ago

To be clear - the above typos are not in the policies but in the check-rudder-agent script.

#11 Updated by Nicolas CHARLES almost 5 years ago

good catch Alex !

#12 Updated by Nicolas CHARLES almost 5 years ago

Bug #4604 has been created to track this

#13 Updated by Vincent MEMBRÉ over 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.12, which was released today.
Check out:

Also available in: Atom PDF