Bug #4685: Error on rpm build, unpackaged files - Rudder - Issue Tracker

Actions

Copy link

Bug #4685

closed

User story #4595: Support for AIX (agent only)

User story #4671: Avoid listing files twice in .spec %files section

Error on rpm build, unpackaged files

Added by Vincent MEMBRÉ over 10 years ago. Updated almost 10 years ago.

Status:

Released

Priority:

N/A

Assignee:

Jonathan CLARKE

Category:

Packaging

Target version:

2.10.0

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Since #4671, Rudder is not building anymore on some RPM systems (RHEL5, and sles10) because some files are installed but unpackaged:

see output for RHEL5:

RPM build errors:
Installed (but unpackaged) file(s) found:
   /opt/rudder/bin/vzps.pyc
   /opt/rudder/bin/vzps.pyo
   /opt/rudder/lib/libtokyocabinet.so
   /opt/rudder/lib/libtokyocabinet.so.9

Output for SLES10:

02:55:48 RPM build errors:
02:55:48 Installed (but unpackaged) file(s) found:
02:55:48    /opt/rudder/lib/libtokyocabinet.so
02:55:48    /opt/rudder/lib/libtokyocabinet.so.9

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Project changed from Rudder to 34
Assignee set to Jonathan CLARKE
Parent task set to #4671

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Status changed from New to Pending technical review
Pull Request set to https://github.com/Normation/rudder-packages/pull/283

PR here: https://github.com/Normation/rudder-packages/pull/283

there is two cases here:

   /opt/rudder/lib/libtokyocabinet.so
   /opt/rudder/lib/libtokyocabinet.so.9

Are symlink files, to be included we just want to get them by adding option "-o -type s" to find ( catching also symlinks)

   /opt/rudder/bin/vzps.pyc
   /opt/rudder/bin/vzps.pyo

Here this is much more complicated, these files may be created after the find is called:

https://fedoraproject.org/wiki/Packaging:Python?rd=Packaging/Python#Byte_Compiled_Files

 Normally, byte compilation is done for you by the brp-python-bytecompile script. This script runs after the %install section of the spec file has been processed and byte compiles any .py files that it finds

we decided to update the find command to match python files globally by replacing any files that ends with ".py" by ".py*" so it can match those file if present and also doesn't break if they are missing.

We have done that by piping the result of find in a sed: