Project

General

Profile

Actions

Bug #4984

closed

Some test fails on CFEngine 3.6 as the execresult and returnszero functions are cached at the begining of execution

Added by Nicolas CHARLES over 8 years ago. Updated 4 months ago.

Status:
Released
Priority:
1
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

In CFEgnine 3.6, the functions execresult and returnszero are executed at the start of the runs if not guarded by a class, and their result cached for the whole execution
This brings havoc on our tests as we do rely a lot on this to check the correct behaviour of promises (see https://dev.cfengine.com/issues/6050 )

We cannot simply add

cache_system_functions => "false" 

in the body common control as this is not compatible with CFEngine 3.5

We so need to rewrite most test to have execresult and returnszero guarded by classes

Actions #1

Updated by Nicolas CHARLES over 8 years ago

ok, i've works on this, but it doesn't pass all tests

Actions #2

Updated by Nicolas CHARLES over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/ncf/pull/61

All tests are now working !

https://github.com/Normation/ncf/pull/61

Actions #3

Updated by Nicolas CHARLES over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:26c593ca037e97fcbc5a78b3e38199b01263f7ee.

Actions #4

Updated by Jonathan CLARKE over 8 years ago

Applied in changeset commit:42c6b2e0bade3b0a5415024b48614e73aac84bce.

Actions #5

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #6

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #7

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF