Project

General

Profile

Actions

Bug #5003

closed

Initial promises on server cause an error to be logged due to duplicate "empty_file_before_editing" setting

Added by Jonathan CLARKE over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
4
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Regression:

Description

Running initial promises on a server, I see this message in verbose output:

 !! Multiple "empty_file_before_editing" (boolean) constraints break this promise
Promise (version not specified) belongs to bundle 'install_rsyslogd' in file '/var/rudder/cfengine-community/inputs/distributePolicy/1.0/rsyslogConf.cf' near line 111
Comment: Copying rsyslog conf

It is due to a duplicate edit_defaults attribute:

    policy_server::
      "/etc/rsyslog.d/rudder.conf" 
        create    => "true",
        edit_defaults => empty,
        edit_line => expand_template("${sys.workdir}/inputs/distributePolicy/rsyslog.conf/rudder.conf"),
        edit_defaults => noempty_backup,
        classes => cf2_if_else("rudder_rsyslog_conf_copied", "cannot_copy_rudder_rsyslog_conf"),
        comment => "Copying rsyslog conf";

This was introduced by #4371.

The impact is not that bad: the file actually still gets edited, just not backed up. The rsyslogd service is also restarted if needed, so there is basically no impact apart from the error message.

Actions #1

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/410
Actions #2

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:534577dfd6fa26fc58e48deb830cc9f78f1ce48d.

Actions #3

Updated by Nicolas CHARLES over 8 years ago

Applied in changeset policy-templates:commit:463c2c46c92d4a7054a1377940c61649fc429e41.

Actions #4

Updated by Vincent MEMBRÉ over 8 years ago

  • Subject changed from initial promises on server cause an error to be logged due to duplicate "empty_file_before_editing" setting to Initial promises on server cause an error to be logged due to duplicate "empty_file_before_editing" setting
Actions #5

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder versions that were released today.

Actions

Also available in: Atom PDF