Project

General

Profile

Actions

Bug #5200

closed

Nodes which are not part of distributed architecture displays an error log on agent execution about missing '/opt/rudder/etc/server-roles.d/' directory

Added by Nicolas PERRON over 9 years ago. Updated about 9 years ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The use of cf-promises on nodes display some errors about non existent folder:

2014-07-02T07:19:28-0700    error: Directory '/opt/rudder/etc/server-roles.d/' could not be accessed in lsdir(), (opendir: No such file or directory)
2014-07-02T07:19:29-0700    error: Directory '/opt/rudder/etc/server-roles.d/' could not be accessed in lsdir(), (opendir: No such file or directory)
2014-07-02T07:19:29-0700    error: Directory '/opt/rudder/etc/server-roles.d/' could not be accessed in lsdir(), (opendir: No such file or directory)
2014-07-02T07:19:29-0700    error: Directory '/opt/rudder/etc/server-roles.d/' could not be accessed in lsdir(), (opendir: No such file or directory)


Related issues 1 (0 open1 closed)

Has duplicate Rudder - Bug #5006: Inventory promises spew errors if /opt/rudder/etc/server-roles.d/ directory is not presentRejectedMatthieu CERDA2014-06-12Actions
Actions #1

Updated by Nicolas PERRON over 9 years ago

This happens with cf-promises on nodes as the foldr /opt/rudder/etc/server-roles.d/ does not exist. I suppose the only way to not have these messages is to create this folder everywhere.

Actions #2

Updated by Nicolas PERRON over 9 years ago

  • Status changed from New to Discussion
  • Assignee set to Jonathan CLARKE

I suppose that adding by default an empty folder '/opt/rudder/etc/server-roles.d/' is harmless, isn't it ? What's you opinion Jon ?

Actions #3

Updated by Jonathan CLARKE over 9 years ago

No, the code should be flexible. Add a test to see if the directory exists. Condition all tests in it by that class.

Actions #4

Updated by Jonathan CLARKE over 9 years ago

  • Status changed from Discussion to In progress
  • Assignee changed from Jonathan CLARKE to Nicolas PERRON
Actions #5

Updated by Nicolas PERRON over 9 years ago

  • Status changed from In progress to Discussion
  • Assignee changed from Nicolas PERRON to Jonathan CLARKE

Nicolas PERRON wrote:

I suppose that adding by default an empty folder '/opt/rudder/etc/server-roles.d/' is harmless, isn't it ? What's you opinion Jon ?

This "error" is made by cf-promises. No class will prevent from read the lines leading to these messages.

Actions #6

Updated by Nicolas PERRON over 9 years ago

  • Target version set to 2.11.0~rc2
Actions #7

Updated by Nicolas PERRON over 9 years ago

I was completly wrong about that issue. The problem is from the promise creating inventories and it is possible to stop these errors without make the folder.

Actions #8

Updated by Nicolas PERRON over 9 years ago

  • Project changed from Rudder to 24
  • Status changed from Discussion to Pending technical review
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/443

PR URL added: https://github.com/Normation/rudder-techniques/pull/443

Jon, could you review it please ?

Actions #9

Updated by Nicolas PERRON over 9 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:0c4735f79b6d194a34ba65ddb392f31f1d4aeb66.

Actions #10

Updated by Nicolas PERRON over 9 years ago

Applied in changeset commit:2dfbac7e6342e56a534bb3358049cb7977ba1415.

Actions #11

Updated by Vincent MEMBRÉ over 9 years ago

  • Subject changed from The use of cf-promises display errors about non-existent '/opt/rudder/etc/server-roles.d/' on nodes to Nodes which are not part of distributed architecture displays an error log on agent execution about missing '/opt/rudder/etc/server-roles.d/' directory
Actions #12

Updated by Vincent MEMBRÉ over 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.0~rc2 (announcement , changelog), which was released today.

Actions #13

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 24 to Rudder
  • Category set to Techniques
Actions

Also available in: Atom PDF