Project

General

Profile

Actions
Copy link

Bug #5381

closed

ncf builder does not escape automatically double quotes, leading to broken Techniques

Added by Matthieu CERDA over 9 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
1
Assignee:
Jonathan CLARKE
Category:
Generic methods
Target version:
ncf-0.x
Pull Request:
https://github.com/Normation/ncf/pull/95
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

The double quotes need to be:
  • Escaped during CFEngine code generation
  • Unescaped before beeing displayed to the user

Failure to do so would lead to broken CFEngine code.

Actions
Copy link
 #1

Updated by Matthieu CERDA over 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/ncf/pull/95

PR is ready !

Actions
Copy link
 #2

Updated by Matthieu CERDA over 9 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:a12c553f09b1e626497125acf088523288883e46.

Actions
Copy link
 #3

Updated by Jonathan CLARKE over 9 years ago

Applied in changeset commit:9f4dd1bbeb0a327a70a1b90ad4bec0658131150d.

Actions
Copy link
 #4

Updated by Nicolas PERRON over 9 years ago

  • Target version changed from 2.11.3 to 2.11.2
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.11.2 to 0.x
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #7

Updated by Alexis Mousset almost 2 years ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions
Copy link
 #8

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions
Copy link

Also available in: Atom PDF