Project

General

Profile

Actions
Copy link

Bug #5429

closed

remove use of proxy in curl on Windows, as it is an invalid option

Bug #5429: remove use of proxy in curl on Windows, as it is an invalid option

Added by Nicolas CHARLES almost 12 years ago. Updated over 11 years ago.

Status:
Released
Priority:
N/A
Assignee:
Jonathan CLARKE
Category:
System techniques
Target version:
2.10.7
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Curl on with (at least the one we ship) don't support proxy option.
It's been removed for the post of inventory part, but not the get of uuid, hence it fails

Updated by Nicolas CHARLES almost 12 years ago Actions
Copy link
 #1

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/466

Updated by Vincent MEMBRÉ almost 12 years ago Actions
Copy link
 #2

  • Target version changed from 2.10.5 to 2.10.6

Updated by Nicolas CHARLES almost 12 years ago Actions
Copy link
 #3

  • Assignee changed from Benoît PECCATTE to Jonathan CLARKE

Jon, could you review this ? thank you

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
 #4

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

I don't think simply removing the proxy option is a good idea.

The reason we introduced this is explained in #3383, but let me summarize: often the http_proxy environment variable is defined on servers, to enable tools to "get out" on the internet (for example to hit package repositories, download software, etc...).

However, these proxies are usually only configured to route HTTP traffic outside of the corporate network. But Rudder's HTTP requests almost always target a HTTP server inside the network, possibly in some sort of network-control-area, that is unknown (or deliberately forbidden) by the proxy server. This is why we currently force curl to use no proxy.

I understand that this Pull Request is based on the fact that the "--proxy" option doesn't exist on the version of curl for Windows you're using, but I'd like to be sure this is the best approach to fixing this. What are our other options?

For example, some ideas:
  • Are we just using a really old version of curl, and therefore upgrading would be enough?
  • How does curl use/not use a proxy if the --proxy option is not available? It must be able to, this is basic HTTP-fu.
  • Is there an equivalent mechanism in Windows to the http_proxy environment variable in UNIX that we could/should use?

Updated by Matthieu CERDA almost 12 years ago Actions
Copy link
 #5

  • Target version changed from 2.10.6 to 2.10.7

Updated by Nicolas CHARLES almost 12 years ago Actions
Copy link
 #6

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE

Updated by Nicolas CHARLES almost 12 years ago Actions
Copy link
 #7

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:f614de222c16379e343ff8f2f2feeb9a45cf5617.

Updated by Jonathan CLARKE almost 12 years ago Actions
Copy link
 #8

Applied in changeset policy-templates:commit:2fffe5af7acb1b6a0507b7e183c76da423ff5d74.

Updated by Vincent MEMBRÉ over 11 years ago Actions
Copy link
 #9

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.7 and 2.11.4, which were released today.

Actions
Copy link

Also available in: PDF Atom