Project

General

Profile

Actions

Bug #5811

closed

The rudder-agent SPEC file does not handle bundled Openssl or not conditions properly

Added by Matthieu CERDA over 9 years ago. Updated about 9 years ago.

Status:
Released
Priority:
1
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

We currently package OpenSSL only if the condtion "use_system_openssl" is true in the package SPEC file.

Problem is, the condition to do so is broken:

# Catch-all
%define use_system_openssl true

## 1 - RHEL: Bundled for pre-el5 oses
##
### Pre el5 have reached the end of production phase,
### and are thus in Extended Life phase.
### See. https://access.redhat.com/support/policy/updates/errata/
##
%if 0%{?rhel} && 0%{?rhel} < 5
%define use_system_openssl false
%else
%define use_system_openssl true
%endif

## 3 - SLES: Bundled for pre-sles11 oses
##
### SLES 11 OSes come with OpenSSL 0.9.8h,
### which is recent enough.
##
%if 0%{?sles_version} && 0%{?sles_version} < 11
%define use_system_openssl false
%else
%define use_system_openssl true
%endif

What happens is, on RHEL3:
  • The condition RHEL is evaluated: rhel 3 < rhel 5, use_system_openssl is set to false => Good !
  • The condition SLES is evaluated: Not a SLES system, use_system_openssl is set to true => FFFF@{#@{#~!!!!!

We need to just rely on the catch-all condition ( use_system_openssl = true ) and add OS-specific exceptions.


Related issues 1 (0 open1 closed)

Related to Rudder - User story #5147: Include our own OpenSSL for non maintained oses in rudder-agent packageReleasedJonathan CLARKE2014-10-20Actions
Actions #1

Updated by Matthieu CERDA over 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/528
Actions #2

Updated by Matthieu CERDA over 9 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset rudder-packages|commit:5c8e23eb85ad3eed68c32525a14c8326a28d55df.

Actions #3

Updated by Jonathan CLARKE over 9 years ago

Applied in changeset rudder-packages|commit:76d7a06ca19f3d1b549fabde34eee7187831ae4b.

Actions #4

Updated by Vincent MEMBRÉ over 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.5, which was released today (16/12/14)

Actions #5

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF