Project

General

Profile

Bug #6695

API Parameters create "overridable" boolean check doesn't work

Added by Francois BAYART over 4 years ago. Updated about 4 years ago.

Status:
Released
Priority:
N/A
Category:
API
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

I'm trying to create a parameter with API and I have an error with "overridable", documentation ( http://www.rudder-project.org/rudder-api-doc/#api-Parameters-createGroup ) said it's a Boolean and example show a boolean.

But it seems to be a string, in "rudder/rudder-web/src/main/scala/com/normation/rudder/web/rest/RestExtractorService.scala" you use extractOneValueJson and use convertToBoolean instead of extractJsonBoolean I think.

But I don't know if the documentation is wrong or if it's the rudder code.

Associated revisions

Revision 4679e70b (diff)
Added by Vincent MEMBRÉ about 4 years ago

Fixes #6695: API Parameters create "overridable" boolean check don't work

Revision aba3efd7 (diff)
Added by Vincent MEMBRÉ about 4 years ago

Fixes #6695: API Parameters create "overridable" boolean check don't work

Revision 5c5c7f25
Added by François ARMAND about 4 years ago

Merge pull request #978 from VinceMacBuche/bug_6695/api_parameters_create_overridable_boolean_check_don_t_work

Fixes #6695: API Parameters create \"overridable\" boolean check don't work

Revision 2ab09e50
Added by François ARMAND about 4 years ago

Merge pull request #978 from VinceMacBuche/bug_6695/api_parameters_create_overridable_boolean_check_don_t_work

Fixes #6695: API Parameters create \"overridable\" boolean check don't work

History

#1

Updated by Vincent MEMBRÉ over 4 years ago

  • Assignee set to Vincent MEMBRÉ
  • Target version set to 2.10.15

Thanks you François!

The code is wrong, and you are right, it should use extractJsonBoolean

A workaround, use a string "false" or "true"

#2

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.15 to 2.10.16
#3

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.16 to 2.10.17
#4

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.17 to 2.10.18
#5

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.18 to 2.10.19
#6

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.10.19 to 2.10.20
#7

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from New to In progress
#8

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/978
#9

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#11

Updated by Vincent MEMBRÉ about 4 years ago

  • Subject changed from API Parameters create "overridable" boolean check don't work to API Parameters create "overridable" boolean check doesn't work
#12

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.20, 2.11.17, 3.0.12 and 3.1.5 which were released today.

Also available in: Atom PDF