Bug #6796: generic methods permissions (non recursive) is indeed recursive - Rudder - Issue Tracker

Actions

Copy link

Bug #6796

closed

generic methods permissions (non recursive) is indeed recursive

Added by Nicolas CHARLES over 9 years ago. Updated over 2 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Nicolas CHARLES

Category:

Generic methods

Target version:

ncf-0.x

Pull Request:

https://github.com/Normation/ncf/pull...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Using "method_call" usebundle => permissions("/chroot/sftp", "711", "root", "root") will recursively change permissions on /chroot/sftp, which is not what is expected

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

depth => "0" seems to do the same as depth => "1".

A solution could be to remove the depth_search when depth is 0.

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

https://github.com/cfengine/core/blob/6a4d6f60f7061f6afd1a3ae8c4bdae5edb6071c6/cf-agent/verify_files_utils.c#L2208

When there is a depth_search attribute, cf-engine only tests recursion depth after browsing the base directory, so a depth of 0 and 1 have the same effect.

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

In the case of file copy, the depth is handled correctly, only the base dir is created. The problem only happens in the DepthSearch function which manages file attributes updates.

Actions

Copy link