Project

General

Profile

Actions
Copy link

Bug #7237

closed

no pid check in rudder-agent init script

Added by Francois BAYART about 9 years ago. Updated almost 8 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
Benoît PECCATTE
Category:
Agent
Target version:
3.1.19
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I have the crazy idea to run every often "service rudder-agent start", so I'm testing this to be sure it's possible and the result seems to be not.

service rudder-agent start && service rudder-agent start && ps fax

=>
28066 ? Ss 0:00 /var/rudder/cfengine-community/bin/cf-serverd
29955 ? Ss 0:00 /var/rudder/cfengine-community/bin/cf-execd
30342 ? Ss 0:00 /var/rudder/cfengine-community/bin/cf-execd

the cf-execd PID is present ( /var/rudder/cfengine-community/cf-execd.pid ) with the value of the last started process.

In the source code (line 188) https://github.com/Normation/rudder-packages/blob/master/rudder-agent/SOURCES/rudder-agent.init#L188 the seems missed just a comment "# Presence of PID file"

After few minutes the cf-execd processes are all killed.

Actions
Copy link
 #1

Updated by Vincent MEMBRÉ about 9 years ago

  • Assignee set to Benoît PECCATTE
  • Target version set to 2.10.18

François, what would be the expected behavior ?

Matthieu, benoit, what should be done here ?

I assign 2.10 version since we should check if it is ok there before

Actions
Copy link
 #2

Updated by Francois BAYART about 9 years ago

Vincent MEMBRÉ wrote:

François, what would be the expected behavior ?

start nothing if the process is started.

https://gist.github.com/frbayart/4e1bf257690ba2298460

Actions
Copy link
 #3

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.18 to 2.10.19
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.19 to 2.10.20
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.20 to 277
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 277 to 2.11.18
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.11.18 to 2.11.19
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.11.19 to 2.11.20
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.20 to 2.11.21
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.24 to 308
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 308 to 3.1.14
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions
Copy link
 #20

Updated by Benoît PECCATTE almost 8 years ago

  • Status changed from New to Rejected

This seems to be fixed now.
Feel free to reopen if not.

Actions
Copy link

Also available in: Atom PDF