Project

General

Profile

Bug #7625

Not accepted node reports trigger compliance processing

Added by François ARMAND about 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
2
Category:
Web - Compliance & node report
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

When we are receving new reports for an agent run, we are invalidating compliance for that node and calculating it back. Problem: the process is triggered for any node, even pendind, deleted, or even completly unknown nodes.

This waste resources for nothing, and so only accepted node should trigger the compliance calcul.

For history, I'm letting the old bug description:

For some reason, it seems that pending nodes are taken into consideration when calculating compliance.

So we get message like:

 WARN  explain_compliance.1e0ab778-0a9e-4d44-902b-60842ed09120 - Node '1e0ab778-0a9e-4d44-902b-60842ed09120' sent reports for run at 'VersionNotFound(2015-12-16T00:16:34.000Z,None)' (with  no configuration ID). No expected configuration matches these reports.

They should not, because either it is blattlantly false (we are using nodes that are clearly NOT in any rule to calculate the compliance of the rule), or a waste of time (we are spending time calculating things for nodes, and we are sure that these things won't be used).

#1

Updated by Jonathan CLARKE about 5 years ago

  • Tags set to Quick and important
#2

Updated by Jonathan CLARKE about 5 years ago

  • Priority changed from 4 to 2
#3

Updated by François ARMAND about 5 years ago

  • Subject changed from Pending Nodes are considered for compliance to Not accepted node reports trigger compliance processing
  • Description updated (diff)
  • Status changed from New to In progress

Changing bug text now that we know it has nothing to do with pending nodes.

#4

Updated by François ARMAND about 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1025
#5

Updated by François ARMAND about 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#6

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.0.13, 3.1.6 and 3.2.0 which were released today.

Also available in: Atom PDF