Project

General

Profile

Actions
Copy link

Bug #8261

closed

Warn when the string length reaches the maximum value supported by the agent

Added by Alexis Mousset over 8 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Web - Technique editor
Target version:
ncf-0.x
Pull Request:
https://github.com/Normation/ncf/pull...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

The builder should display a warning and/or limit the field lengths according to the limits in the agent.

Subtasks 2 (0 open — 2 closed)

User story #8323: Limit the length of technique namesReleasedVincent MEMBRÉActions
User story #8465: Limit length of technique names to 100 chars in the ncf apiReleasedFrançois ARMANDActions
Actions
Copy link
 #1

Updated by Alexis Mousset over 8 years ago

  • Subject changed from Warn when the string length reacheqs the maximum value supported by the agent to Warn when the string length reaches the maximum value supported by the agent
Actions
Copy link
 #2

Updated by Jonathan CLARKE over 8 years ago

  • Assignee set to Raphael GAUTHIER

Raphael, please add a check in ncf-builder to ensure that any fields with > 2000 characters cannot be extended, and display the following error message to the user: "Fields over 2000 characters are currently not supported. Please insert your content into a file, and copy it with a file_copy_* method, or use a template."

Actions
Copy link
 #3

Updated by Jonathan CLARKE over 8 years ago

  • Project changed from Rudder to 41
  • Category deleted (Web - Technique editor)
  • Target version set to 0.x
Actions
Copy link
 #4

Updated by Raphael GAUTHIER over 8 years ago

  • Status changed from New to In progress
Actions
Copy link
 #5

Updated by Alexis Mousset over 8 years ago

Classes conditions are also cut at 2048 when parsed (and hit the concat() max argument length at 4096 when writting a longer one).

Actions
Copy link
 #6

Updated by Alexis Mousset over 8 years ago

Technique names should be kept quite short, because the name is used in the filename, which should be compatible with all filesystems.

For most systems the limit is around 255, and we need room for the extension. It may be a migration issue though, because some people may use names that are around the limit on some filesystems.

We should not break their installation, as it is not possible to change the same that has be given at creation, opening another ticket for this issue.

Actions
Copy link
 #7

Updated by Raphael GAUTHIER over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Raphael GAUTHIER to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/ncf/pull/360
Actions
Copy link
 #8

Updated by Anonymous over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:e93d2ae398c9e33aab0e97046b374fc962b3b5fe.

Actions
Copy link
 #9

Updated by Vincent MEMBRÉ about 8 years ago

  • Category set to Technique editor - UI/UX
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ about 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in ncf version bundled with Rudder 2.11.24, 3.1.13 and 3.2.6 which were released today.

Actions
Copy link
 #11

Updated by Alexis Mousset over 2 years ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions
Copy link
 #12

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Technique editor - UI/UX to Web - Technique editor
Actions
Copy link

Also available in: Atom PDF