Project

General

Profile

Actions
Copy link

User story #8782

closed

User story #8629: Allows generation-time javascript eval in directive parameters

Fix details on script (remove $ from token and fix double password prefix)

Added by Vincent MEMBRÉ over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Benoît PECCATTE
Category:
Web - Config management
Target version:
3.1.12
Pull Request:
https://github.com/Normation/rudder/p...
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

We decided to use 'evaljs:' and not '$evaljs:' as token to identify our script variables

Files

0001-Refs-8629-correct-generation-of-password.patch (2.64 KB) 0001-Refs-8629-correct-generation-of-password.patch Vincent MEMBRÉ, 2016-07-29 01:23
Actions
Copy link
 #1

Updated by Vincent MEMBRÉ over 8 years ago

Nicolas pointed me out that there is a double password prefix to when a password is evaluated.

He provided a patch that I put here as well and will put in a PR here

Actions
Copy link
 #2

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from New to In progress
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder/pull/1153
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Alexis Mousset over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.12 and 3.2.5 which were released today.

Actions
Copy link

Also available in: Atom PDF