Actions
Bug #8839
closedArchitecture #7915: Merge initial promises and system techniques
Broken initial promises on 3.3
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Description
agent1:/var/rudder/cfengine-community/inputs # diff -cr /opt/rudder/share/initial-promises/ . diff -cr /opt/rudder/share/initial-promises/common/1.0/cron-setup.cf ./common/1.0/cron-setup.cf *** /opt/rudder/share/initial-promises/common/1.0/cron-setup.cf Thu Aug 11 15:52:38 2016 --- ./common/1.0/cron-setup.cf Thu Aug 11 16:19:39 2016 *************** *** 55,61 **** # Cleanup the pre-4.0 crontab "/var/spool/cron/crontabs/root" edit_defaults => noempty_backup, ! edit_line => delete_lines_matching("0,5,10,15,20,25,30,35,40,45,50,55 \* \* \* \* /usr/bin/test -x /opt/rudder/bin/check-rudder-agent && /opt/rudder/bin/check-rudder-agent >/dev/null"), # Add Rudder entry "/var/spool/cron/crontabs/root" --- 55,61 ---- # Cleanup the pre-4.0 crontab "/var/spool/cron/crontabs/root" edit_defaults => noempty_backup, ! edit_line => delete_lines_matching("0,5,10,15,20,25,30,35,40,45,50,55 \* \* \* \* /usr/bin/test -x /opt/rudder/bin/check-rudder-agent && /opt/rudder/bin/check-rudder-agent >/dev/null"); # Add Rudder entry "/var/spool/cron/crontabs/root" diff -cr /opt/rudder/share/initial-promises/promises.cf ./promises.cf *** /opt/rudder/share/initial-promises/promises.cf Thu Aug 11 15:52:38 2016 --- ./promises.cf Thu Aug 11 16:19:23 2016 *************** *** 48,54 **** inputs => { @{va.inputs_list}, ! "rudder-system-directives.cf", }; bundlesequence => { --- 48,54 ---- inputs => { @{va.inputs_list}, ! "common/1.0/rudder-system-directives.cf", }; bundlesequence => { *************** *** 68,76 **** "endExecution" }; - # all other inputs are loaded by body file control in rudder-system-directives.cf and rudder-directives.cf - "inputs_list" slist => { @{ncf_inputs} }; - "common_bs" slist => { "startup", "check_disable_agent", --- 68,73 ---- *************** *** 107,116 **** !policy_server:: # This bundle is duplicated to avoid having empty lists and cfnull in bundlesequence ! "specific_bs" slist => { "check_binaries_freshness" } ! ! # all other inputs are loaded by body file control in rudder_system_directives.cf and rudder_directives.cf ! "inputs_list" slist => { @{ncf_inputs} }; !android.!windows:: "rudder_var" string => "/var/rudder"; --- 104,110 ---- !policy_server:: # This bundle is duplicated to avoid having empty lists and cfnull in bundlesequence ! "specific_bs" slist => { "check_binaries_freshness" }; !android.!windows:: "rudder_var" string => "/var/rudder"; *************** *** 154,159 **** --- 148,156 ---- # Need to remove cf_null from the list "ncf_inputs" slist => filter("${ncf_path}/cf_null", "raw_ncf_inputs", "false", "true", 10000); + + "inputs_list" slist => { @{ncf_inputs} }; + # definition of the machine roles # This node doesn't have any specific role # policy_server and root_server migrated to rudder_roles
Updated by Alexis Mousset over 8 years ago
- Status changed from New to In progress
Updated by Alexis Mousset over 8 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Alexis Mousset to Jonathan CLARKE
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/1007
Updated by Benoît PECCATTE about 8 years ago
- Status changed from Pending technical review to In progress
- Assignee changed from Jonathan CLARKE to Benoît PECCATTE
I'm taking over this ticket!
Updated by Benoît PECCATTE about 8 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Benoît PECCATTE to Alexis Mousset
- Pull Request changed from https://github.com/Normation/rudder-techniques/pull/1007 to https://github.com/Normation/rudder-techniques/pull/1018
Updated by Benoît PECCATTE about 8 years ago
- Assignee changed from Alexis Mousset to Jonathan CLARKE
Updated by Alexis Mousset about 8 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder-techniques|235a5dff878f76fce60f87f5b2f22f46ab389ff5.
Updated by Benoît PECCATTE about 8 years ago
- Target version changed from 4.0.0~rc2 to 318
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 318 to 4.0.0~rc2
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 4.0.0~rc2 to 4.0.0~rc1
Updated by Alexis Mousset about 8 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 4.0.0 which was released the 10th November 2016.
Actions