Project

General

Profile

Actions

User story #8920

closed

User story #8919: Remove modifications made to the inventory by the agent

Use FusionInventory system attributes instead of Rudder's custom ones

Added by Matthieu CERDA over 7 years ago. Updated about 6 years ago.

Status:
Released
Priority:
2
Category:
Web - Nodes & inventories
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

We currently add the following "system related" attributes to the inventories before sending them:
  • USERSLIST
  • PROCESSORS
They are now obsolete, since FusionInventory provides more complete implementations builtin now:
  • USERSLIST:
    <USERSLIST>
    <USER>root</USER>
    </USERSLIST>
    = vers =>
        <LOCAL_USERS>
          <HOME>/root</HOME>
          <ID>0</ID>
          <LOGIN>root</LOGIN>
          <NAME>root</NAME>
          <SHELL>/bin/bash</SHELL>
        </LOCAL_USERS>
    

    *PROCESSORS:
    <PROCESSORS>
            <PROCESSOR>
                    <VENDOR>GenuineIntel</VENDOR>
                    <FAMILY>6</FAMILY>
                    <MODEL>2</MODEL>
                    <NAME>QEMU Virtual CPU version 0.12.5</NAME>
                    <STEPPING>3</STEPPING>
                    <FREQUENCY>1862.301</FREQUENCY>
            </PROCESSOR>
    </PROCESSORS>
    = vers =>
        <CPUS>
          <ARCH>i386</ARCH>
          <FAMILYNAME>Other</FAMILYNAME>
          <FAMILYNUMBER>6</FAMILYNUMBER>
          <ID>23 06 00 00 FD FB 8B 07</ID>
          <MANUFACTURER>Intel</MANUFACTURER>
          <MODEL>2</MODEL>
          <NAME>QEMU Virtual CPU version 0.12.5</NAME>
          <SPEED>2000</SPEED>
          <STEPPING>3</STEPPING>
        </CPUS>
    

I guess now is time to get rid of the ones we add and leverage the builtin ones :)

Actions #1

Updated by Matthieu CERDA over 7 years ago

Careful though, we tend to use "upper" XPATH bounds to iterate on things ( USERSLIST-USER-/USERSLIST ) whereas fusion seems to just add multiple entries ( LOCAL_USERS ). Same goes for the PROCESSORS / CPUS.

Actions #2

Updated by Matthieu CERDA over 7 years ago

We should also, if not done already, remove the "VM" custom tag parsing. We already are able to parse VIRTUALMACHINES Fusion-provided one, our tag is unnecessary.

Actions #3

Updated by François ARMAND over 7 years ago

  • Target version changed from 4.0.0~rc2 to 4.1.0~beta1
Actions #4

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 4.1.0~beta1 to 4.1.0~beta2
Actions #5

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.1.0~beta2 to 4.1.0~beta3
Actions #6

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.1.0~beta3 to 4.1.0~rc1
Actions #7

Updated by François ARMAND about 7 years ago

  • Target version changed from 4.1.0~rc1 to 4.2.0~beta1
Actions #8

Updated by Alexis Mousset almost 7 years ago

  • Target version changed from 4.2.0~beta1 to 4.2.0~beta2
Actions #9

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.2.0~beta2 to 4.2.0~beta3
Actions #10

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.2.0~beta3 to 4.2.0~rc1
Actions #11

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.2.0~rc1 to 4.2.0~rc2
Actions #12

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.2.0~rc2 to 4.2.0
Actions #13

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.2.0 to 4.2.1
Actions #14

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.2.1 to 4.2.2
Actions #15

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.2.2 to 4.2.3
Actions #16

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.2.3 to 4.2.4
Actions #17

Updated by François ARMAND about 6 years ago

  • Target version changed from 4.2.4 to 4.1.10
Actions #18

Updated by François ARMAND about 6 years ago

In 4.1, the state is:

- we already use fusion VIRTUALMACHINES,
- we already use fusion CPUS,

So for User / local accounts, we just need to parse both and deduplicate to be forward compatible (and be able to remove all of that in 4.3).

Actions #19

Updated by François ARMAND about 6 years ago

  • Status changed from New to In progress
Actions #20

Updated by François ARMAND about 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/ldap-inventory/pull/128
Actions #21

Updated by François ARMAND about 6 years ago

Also, as of 4.1, start to parse back HARDWARE/UUID for mother board id. It is more up to date than our MACHINEID tag.

Actions #22

Updated by Rudder Quality Assistant about 6 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions #23

Updated by François ARMAND about 6 years ago

  • Status changed from Pending technical review to Pending release
Actions #24

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.

Actions

Also available in: Atom PDF