Project

General

Profile

Actions

Bug #9091

closed

The "rudder" init script tries to stop slapd before jetty

Added by Matthieu CERDA over 4 years ago. Updated over 4 years ago.

Status:
Released
Priority:
1
Category:
System integration
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

See:

root@amnesiac:~# service rudder stop
Stopping Rudder services:
 * rudder-slapd...>HERE<OK
 * postgresql...        OK
 * rudder-jetty...      OK
 * rudder-agent...      OK

The symptom here is that I tried to stop Rudder on a quite busy system, and the script stopped at the ">HERE<" on the previous sample.

The reason was that when we run service rudder-slapd stop (it is the case here), the script runs a slapcat to backup the configuration before halting slapd. In this case, the slapcat seemed to be stuck (hogging a lot of CPU ressources), but as soon as I brutally killed rudder-jetty, it completed and carried on with the other steps.

I assume that the slapcat does not handle well heavy concurrent access to the database, and I feel that the solution here is quite simple: we should never stop a provider (database) before its consumers (Jetty). The reason is, that the provider may get stuck waiting for the consumer to stop sending requests before halting to halt in a clean / consistent way.

We should probably stop rudder-jetty and rudder-agent before rudder-slapd and postgresql ?

Actions #1

Updated by Matthieu CERDA over 4 years ago

  • Status changed from New to In progress
  • Assignee set to Matthieu CERDA
Actions #2

Updated by Matthieu CERDA over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1083
Actions #3

Updated by Matthieu CERDA over 4 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #4

Updated by Vincent MEMBRÉ over 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.15/14 and 3.2.8/7 which were released today.

Actions

Also available in: Atom PDF