Project

General

Profile

Actions

Bug #9530

closed

Bug #9518: When we just apply a configuration, reports is "missing" (not "pending")

Each policy generation lead to a new nodeconnfigid even without promise written

Added by François ARMAND over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Compliance & node report
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

In the parent task, we changed the way node config id are generated to have them unique, introducing a salt (current time).

The cache verification and everything works fine, but even WITHOUT cache invalidation, we are writting a new expected node configuration. As the promises are not written, this lead to a case were the node send reports for a given config id, but Rudder is expecting them for an other => error.

So it seems that somewhere we are a little to zealous about writting new expected configuration.

Actions #1

Updated by François ARMAND over 7 years ago

  • Translation missing: en.field_tag_list set to Blocking 4.0

This is of course blocking 4.0.

Actions #2

Updated by François ARMAND over 7 years ago

Moreover, we weren't very smart in the way we are building the config version, because:

System.currentMillis + XXX.hashCode => that's the same 4 byte that are impacted, something like "System.currentMillis + XXX.hashCode.toLong<<4" would lead to a better distribution.

And we should use the generation time for the salt, so it is possible to find back the hash from the "beginDate".

Actions #3

Updated by François ARMAND over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1340
Actions #4

Updated by François ARMAND over 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #5

Updated by Alexis Mousset over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.0 which was released the 10th November 2016.

Actions

Also available in: Atom PDF