Project

General

Profile

Actions

Bug #9815

closed

Remaining self closing tag in HTML 5 files

Added by François ARMAND about 8 years ago. Updated almost 8 years ago.

Status:
Rejected
Priority:
2
Category:
Architecture - Code maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I found these remaining self closing tags:

[/src/main/webapp/templates-hidden/common-layout.html] <lift:bind name="content" />
[/src/main/webapp/templates-hidden/common-layout.html] <div id="successDialogContent" />
[/src/main/webapp/templates-hidden/Popup/expected_policy_popup.html] <expectedpolicypopup:node/>
[/src/main/webapp/templates-hidden/emergency_stop.html] <emergency:images/>
[/src/main/webapp/templates-hidden/emergency_stop.html] <emergency:title/>
[/src/main/webapp/templates-hidden/emergency_stop.html] <emergency:body/>
[/src/main/webapp/templates-hidden/emergency_stop.html] <emergency:button/>
[/src/main/webapp/templates-hidden/components/NodeGroupForm.html] <group:reason />
[/src/main/webapp/templates-hidden/components/NodeGroupForm.html] <group:removeForm/>
[/src/main/webapp/templates-hidden/components/ComponentRuleEditForm.html] <span id="ruleName"/>
[/src/main/webapp/templates-hidden/components/ComponentRuleEditForm.html] <span id="ruleCategory"/>
[/src/main/webapp/templates-hidden/components/ComponentRuleEditForm.html] <span id="ruleShortDescription"/>
[/src/main/webapp/templates-hidden/components/ComponentRuleEditForm.html] <span id="ruleLongDescription"/>
[/src/main/webapp/templates-hidden/components/ComponentRuleEditForm.html] <ul id="changeRequestList"/>
[/src/main/webapp/templates-hidden/components/ComponentRuleEditForm.html] <div class="hierarchySpacer"/>
[/src/main/webapp/templates-hidden/components/directiveInput.html] <textarea class="form-control textarea monospace-font" ng-model="current.value" ng-trim="false" />
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <span/>
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <span/>
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <span/>
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <files:delete/>
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <line:name />
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <line:size />
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <line:date />
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <line:delete />
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <div id="uploaded_files_grid_filter_area"/>
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <files:select />
[/src/main/webapp/secure/nodeManager/uploadedFiles.html] <files:upload />
[/src/main/webapp/secure/nodeManager/nodes.html] <div data-lift="node.Nodes.table" />
[/src/main/webapp/secure/nodeManager/nodes.html] <div data-lift="node.Nodes.loadData" />
[/src/main/webapp/secure/configurationManager/index.html] <lift:index.configurationManager.index/>
[/src/main/webapp/secure/configurationManager/parameterManagement.html] <div class="lift:configuration.ParameterManagement.display" />
[/src/main/webapp/secure/configurationManager/parameterManagement.html] <div id="globalParameterForm" />
[/src/main/webapp/secure/configurationManager/parameterManagement.html] <div id="createGlobalParameterContainer" />
[/src/main/webapp/secure/configurationManager/parameterManagement.html] <div id="deletionPopup" class="nodisplay" />
[/src/main/webapp/secure/configurationManager/ruleManagement.html] <div id="createRuleContainer" />
[/src/main/webapp/secure/utilities/index.html] <lift:index.Utilities.index/>
[/src/main/webapp/secure/utilities/changeRequests.html] <span id="actualFilter" style="margin-left:10px; display:inline-block"/>
[/src/main/webapp/secure/administration/index.html] <lift:index.administration.index/>
[/src/main/webapp/secure/administration/policyServerManagement.html] <span id="explanationTooltip" />
[/src/main/webapp/secure/administration/techniqueLibraryManagement.html] <div id="createActiveTechniquesCategoryContainer"/>
[/src/main/webapp/secure/administration/techniqueLibraryManagement.html] <div id="createActiveTechniquesContainer"/>

Are they errors?
If yes, I propose to corrige them and commit the test which found them.


Related issues 1 (0 open1 closed)

Related to Rudder - Architecture #10127: Switch to Scala 2.12 / Lift 3.0 ReleasedVincent MEMBRÉ2017-02-03Actions
Actions #1

Updated by François ARMAND about 8 years ago

  • Status changed from Discussion to In progress
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions #3

Updated by Vincent MEMBRÉ almost 8 years ago

All divs / span are potential problems

Don't think the lift tag are an issue (especially those in unused files emergency and uploadFiles which may be deleted in fact ...)

Actions #4

Updated by Vincent MEMBRÉ almost 8 years ago

  • Status changed from In progress to New
Actions #5

Updated by François ARMAND almost 8 years ago

  • Status changed from New to Rejected

I'm closing that ticket, because the changes were done in 4.1 with the switch to Lift 3.0. And we don't really need to change the working ones in previous version of lift. See #10127 for more details.

Actions #6

Updated by François ARMAND almost 8 years ago

Actions

Also available in: Atom PDF