Rudder

Using slapadd to restore backup fixed the issue

There are several things wrong here:
- The calculation for maxsize in the mdb database config should be more generous
- The migration script should detect this error!

ok, during upgrade, we modify the existing slapd.conf file with

        sed -i 's/^database.*hdb/database    mdb/' "${SLAPD_CONF}" 
        sed -i '/^idlcachesize.*/d' "${SLAPD_CONF}" 
        sed -i '/^cachesize.*/d' "${SLAPD_CONF}" 

but we don't set the

maxsize

as discussed with Alexis, we need to set the maxsize before we slapadd.
But the computation method of maxsize is quite complex, and we don't want to duplicate that part - and it's done in the rudder-slapd init script. We can't simply start/stop rudder-slapd to correct the value, as it will generate a new backup and prevent restoring old data
So we'll extract the maxsize computation and replacement in another script, that will be called by init script to keep behaviour, and by upgrade script

it doesn't seems completly fixed

INFO: Reloading syslogd...  Done
INFO: Stopping rudder-slapd... Done
rudder-slapd[4744]: [INFO] Using /etc/default/rudder-slapd for configuration
ERROR: Failed to restore data from old format into the new format
You can reimport manually the data from backup file /var/rudder/ldap/backup/openldap-data-pre-upgrade-20170313122822.ldif
INFO: Restarting rudder-slapd... Done
INFO: A back up copy of /etc/init.d/rudder-agent has been created in /var/backups/rudder
INFO: A back up copy of /etc/default/rudder-agent has been created in /var/backups/rudder

But, i do have a working Rudder, with apparently all configs there.

So, the condition in packaging is wrong, see subticket