Architecture #10825
closed
Bad comparison in unique variable
Added by François ARMAND over 7 years ago.
Updated over 7 years ago.
Category:
Architecture - Internal libs
Description
We have a bad comparison in "def copyWithSetVariables(variables:Seq[Variable]) : Cf3PolicyDraft" which alway lead to always copy variables, changing their update time even if not needed.
variableMap.get(variable.spec.name) match {
case None => Some(variable)
case Some(values) => if(values == variable.values) None else Some(variable) //here, it is Some(otherVariable), not values!
}
- Target version changed from 3.1.21 to 4.1.4
Only changing it in 4.1, because the impact seems to be at most in performance, and I don't want to add an unseen consistency bug in earlier version where the code is more complexe than 4.1.
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Nicolas CHARLES
- Pull Request set to https://github.com/Normation/rudder/pull/1657
- Status changed from Pending technical review to Pending release
- Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.4 which was not released (see changelog for details), and is available in Rudder 4.1.5.
Also available in: Atom
PDF