Project

General

Profile

Actions
Copy link

Bug #10908

closed

When hooks in policy-generation-node-ready or policy-generation-node-finished fails, there is no error in the generation

Added by Nicolas CHARLES over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
Web - Config management
Target version:
4.1.4
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

Error codes of hooks in policy-generation-node-ready or policy-generation-node-finished are not handled: if we return 1, it happily continues generation and finishes

It seems it's because return code is encapsulated in a Full - so it's always ok
So there is no real check on policy generation validity

Actions
Copy link
 #1

Updated by François ARMAND over 7 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions
Copy link
 #2

Updated by François ARMAND over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/1664
Actions
Copy link
 #3

Updated by François ARMAND over 7 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #4

Updated by Alexis Mousset over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.4 which was not released (see changelog for details), and is available in Rudder 4.1.5.

Actions
Copy link

Also available in: Atom PDF