Bug #12332: Wrong api method name - Rudder - Issue Tracker

Actions

Copy link

Bug #12332

closed

Wrong api method name

Added by Félix DALLIDET over 6 years ago. Updated over 6 years ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Category:

Documentation

Target version:

4.1.11

Pull Request:

https://github.com/Normation/rudder-a...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

The API has 2 methods defined with the same name, it does not broke the API because the args are differents but the cli can not choose the right function to execute.

"listDirectives" appears 2 times: one for list all directives and one for list all directives given from a technique name.
This last function should have a different name.

Actions

Copy link

Updated by Félix DALLIDET over 6 years ago

Target version set to 4.1.11

Actions

Copy link

Updated by Félix DALLIDET over 6 years ago

Status changed from New to In progress
Assignee set to Félix DALLIDET

Actions

Copy link

Updated by Félix DALLIDET over 6 years ago

Status changed from In progress to Pending technical review
Assignee changed from Félix DALLIDET to François ARMAND
Pull Request set to https://github.com/Normation/rudder/pull/1886

PR https://github.com/Normation/rudder/pull/1886

Actions

Copy link

Updated by François ARMAND over 6 years ago

I thought that the python CLI was parsing the documentation to be build. Are you sure that changing the scala code will solve your problem? Should you not change it here: https://github.com/Normation/rudder-api-doc/edit/master/src/api_v2/techniques.md ?

Actions

Copy link

Updated by François ARMAND over 6 years ago

Status changed from Pending technical review to Discussion
Assignee changed from François ARMAND to Félix DALLIDET

Actions

Copy link

Updated by Félix DALLIDET over 6 years ago

Status changed from Discussion to Pending technical review
Assignee changed from Félix DALLIDET to François ARMAND

Actions

Copy link

Updated by Vincent MEMBRÉ over 6 years ago

François is right, I do think rudder-cli parse the rudder-api documentation to generate its option !!

Actions

Copy link

Updated by Félix DALLIDET over 6 years ago

Status changed from Pending technical review to In progress
Assignee changed from François ARMAND to Félix DALLIDET

Actions

Copy link

Updated by Félix DALLIDET over 6 years ago

Status changed from In progress to Pending technical review
Assignee changed from Félix DALLIDET to Vincent MEMBRÉ
Pull Request changed from https://github.com/Normation/rudder/pull/1886 to https://github.com/Normation/rudder-api-doc/pull/47

PR https://github.com/Normation/rudder-api-doc/pull/47

Actions

Copy link

#10